Merged
Conversation
senhuang42
force-pushed
the
progress_counter
branch
from
a7e8fda to
a466400
Compare
Cyan4973
reviewed
Apr 30, 2021
|
|
||
| typedef struct FIO_display_prefs_s FIO_display_prefs_t; | ||
|
|
||
| typedef enum { FIO_ps_auto, FIO_ps_never, FIO_ps_always } FIO_progressSetting_e; |
Cyan4973
approved these changes
Apr 30, 2021
Contributor
Cyan4973
left a comment
Cyan4973
left a comment
There was a problem hiding this comment.
Looks good to me !
I'm wondering if there would be a way to automatically test this feature,
though I understand it's a fairly tricky topic.
Maybe redirect stderr to stdout and grep the result for traces (or absence of traces) of the counter ?
This was referenced May 10, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #2556
A while ago, the way zstd interacts with stdin and stdout was refactored, removing any possibility of (de)compressed output to stdout displayed in the terminal to mix with stderr (since that's generally not what we want), so currently
zstdclidoesn't generate a refreshing progress meter when output is going to stdout.This PR adds that possibility back in, but now behind a new flag,
--progress(to go along with --no-progress) that will force the progress meter to display on (de)compression.