[1.5.0] Move zstd_errors.h and zdict.h to lib/ root#2597
Merged
terrelln merged 1 commit intofacebook:devfrom May 4, 2021
Merged
[1.5.0] Move zstd_errors.h and zdict.h to lib/ root#2597terrelln merged 1 commit intofacebook:devfrom
zstd_errors.h and zdict.h to lib/ root#2597terrelln merged 1 commit intofacebook:devfrom
Conversation
terrelln
force-pushed
the
public-headers
branch
2 times, most recently
from
b5750ae to
09149be
Compare
`zstd_errors.h` and `zdict.h` are public headers, so they deserve to be in the root `lib/` directory with `zstd.h`, not mixed in with our private headers.
Cyan4973
approved these changes
May 4, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zstd_errors.handzdict.hare public headers, so they deserve to bein the root
lib/directory withzstd.h, not mixed in with our privateheaders.