Conversation
the new alignment setting is better for gcc-9 and gcc-10 by about ~+5%. Unfortunately, it's worse for essentially all other compilers. Make the new alignment setting conditional to gcc-9+.
terrelln
approved these changes
May 10, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was embarrassed that the updated decoder code
would fare measurably worse on
gcc-9andgcc-10by 5 to 6%.
The new alignment setting is better for gcc-9 and gcc-10 by almost +5%.
Consequently, this version still decodes slower than v1.4.9 on gcc-9 and gcc-10,
but by a more negligible amount < 2%.
Unfortunately, the new setting is worse for essentially all other compilers.
Make the new alignment setting conditional to gcc-9+,
keep previous alignment setting for all other compilers.
As expected, the change is mostly neutral for all other compilers
(one can safely ignore anything <1% as "noise"),
only
gcc-9andgcc-10in "normal" mode are favorably impacted, and by a nice margin.