Add source level deprecation warning disabling to certain tests/utils#2645
Merged
senhuang42 merged 1 commit intofacebook:devfrom May 13, 2021
Merged
Add source level deprecation warning disabling to certain tests/utils#2645senhuang42 merged 1 commit intofacebook:devfrom
senhuang42 merged 1 commit intofacebook:devfrom
Conversation
senhuang42
force-pushed
the
deprecate_macro_tests
branch
from
b3e0c9e to
9f54baf
Compare
Contributor
That might be because |
senhuang42
force-pushed
the
deprecate_macro_tests
branch
from
9f54baf to
24cddbb
Compare
senhuang42
force-pushed
the
deprecate_macro_tests
branch
from
24cddbb to
71ffd88
Compare
Author
|
I have verified that this now builds locally. Still, there is the remaining question of what to do with all the warnings |
Cyan4973
approved these changes
May 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title. This adds the macro to
fuzzer,zstreamtest,fullbench, andPzstd.Also adds
thread_deptarget tofuzzerin meson build, and-Wno-deprecated-declarationsto thepzstdtarget inmeson. For some reason, including the deprecate macro isn't sufficient inPzstd.hI think this is all of them.