Remove additional flag for Visual#2647
Merged
senhuang42 merged 1 commit intofacebook:devfrom May 13, 2021
Merged
Conversation
senhuang42
force-pushed
the
vcx_macro_redef
branch
from
6d23c77 to
8fc3ad6
Compare
Cyan4973
approved these changes
May 13, 2021
Author
|
Hmm, appveyor has been queued for over an hour, not sure how to force it to run. |
Contributor
|
We do have a time-length pb with Appveyor tests. |
Author
Ah, it seems like I don't have permissions to cancel any appveyor runs, but the ones on just PRs seem to be a little faster. |
senhuang42
force-pushed
the
vcx_macro_redef
branch
from
8fc3ad6 to
d3634bf
Compare
Contributor
|
Appveyor tests moved towards d3634bf |
senhuang42
force-pushed
the
vcx_macro_redef
branch
from
d3634bf to
3f4acce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
ZSTD_DISABLE_DEPRECATE_WARNINGSis in the source code itself, including them in vcxproj files will cause aC4005 macro redefinitionwarning. So we should remove them to avoid appveyor failures.Test Plan: