Skip to content

Move mingw tests from appveyor to github actions#2838

Merged
binhdvo merged 1 commit intofacebook:devfrom
binhdvo:appveyormove
Nov 2, 2021
Merged

Move mingw tests from appveyor to github actions#2838
binhdvo merged 1 commit intofacebook:devfrom
binhdvo:appveyormove

Conversation

@binhdvo
Copy link
Copy Markdown
Contributor

@binhdvo binhdvo commented Oct 31, 2021

Moved mingw tests to github actions which allows them to run in parallel. The change of environment surfaced a warning error that's been suppressed.

@Cyan4973
Copy link
Copy Markdown
Contributor

Cyan4973 commented Oct 31, 2021

Good ! With Appveyor CI now down to < 10mn, it should no longer be the iteration bottleneck.

Cyan4973
Cyan4973 reviewed Oct 31, 2021
View reviewed changes
.github/workflows/dev-long-tests.yml Outdated
sh -c "${{matrix.script}}"
IF ("${{matrix.artifact}}" -eq "true")
{
ECHO Creating artifacts
Copy link
Copy Markdown
Contributor

@Cyan4973 Cyan4973 Oct 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so that's something I overlooked regarding this topic.

On top of Windows tests, Appveyor was also used to create the Windows binary packages at release time.
It's my understanding that you transferred this responsibility to Github Actions.

How does it work ?
In which cases are artifact created, and how to access them ?

For example, I note that, in this PR, there is a script section called "upload artifacts", but it's empty (runtime 0s).

Copy link
Copy Markdown

@senhuang42 senhuang42 Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a direct translation from the AppVeyor release artifact process doesn't work, since it seems like AppVeyor will just display any artifacts in the \artifacts folder, whereas I think GH Actions works a bit differently.

There's some documentation here: https://github.com/actions/upload-artifact on how to upload the artifact, it seems you just need an extra step that points to the artifact/directory you'd like to upload.

Copy link
Copy Markdown
Contributor Author

@binhdvo binhdvo Nov 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry I thought I'd gotten it working, I've reverted those tests back to appveyor for now and will try to get them working on GH in a followup.

Copy link
Copy Markdown
Contributor

@Cyan4973 Cyan4973 Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks correct to me,
but just to be on the safe side, have you also been able to test that the artifacts are still generated on Appveyor ?

Copy link
Copy Markdown
Contributor Author

@binhdvo binhdvo Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Artifacts on appveyor branch PR look good:

https://ci.appveyor.com/project/YannCollet/zstd-p0yf0/builds/41368517/job/kckbm0scodyuxp4e/artifacts
https://ci.appveyor.com/project/YannCollet/zstd-p0yf0/builds/41368517/job/s1c9o37ux7qkn38s/artifacts

Copy link
Copy Markdown
Contributor

@Cyan4973 Cyan4973 Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent ! Thanks @binhdvo !

Copy link
Copy Markdown
Contributor Author

@binhdvo binhdvo Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, there are some appveyor failures now, but they don't look related to these changes, investigating.

@binhdvo binhdvo merged commit b399b47 into facebook:dev Nov 2, 2021
senhuang42 pushed a commit to senhuang42/zstd that referenced this pull request Nov 3, 2021
@binhdvo
Move mingw tests from appveyor to github actions (facebook#2838)
ba77106
terrelln added a commit to terrelln/linux that referenced this pull request Nov 16, 2021
@terrelln
lib: zstd: Fix unused variable warning
bb695d1 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
rsalvaterra pushed a commit to rsalvaterra/linux that referenced this pull request Nov 17, 2021
@terrelln @rsalvaterra
lib: zstd: Fix unused variable warning
51c0f14 
The variable `litLengthSum` is only used by an `assert()`, so when
asserts are disabled the compiler doesn't see any usage and warns.

This issue is already fixed upstream by PR #2838 [0]. It was reported
by the Kernel test robot in [1].

Another approach would be to change zstd's disabled `assert()`
definition to use the argument in a disabled branch, instead of
ignoring the argument. I've avoided this approach because there are
some small changes necessary to get zstd to build, and I would
want to thoroughly re-test for performance, since that is slightly
changing the code in every function in zstd. It seems like a
trivial change, but some functions are pretty sensitive to small
changes. However, I think it is a valid approach that I would
like to see upstream take, so I've opened Issue #2868 to attempt
this upstream.

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/
[2] facebook/zstd#2868

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
terrelln added a commit to terrelln/linux that referenced this pull request Nov 17, 2021
@terrelln
lib: zstd: Fix unused variable warning
6e7f9ac 
The variable `litLengthSum` is only used by an `assert()`, so when
asserts are disabled the compiler doesn't see any usage and warns.

This issue is already fixed upstream by PR #2838 [0]. It was reported
by the Kernel test robot in [1].

Another approach would be to change zstd's disabled `assert()`
definition to use the argument in a disabled branch, instead of
ignoring the argument. I've avoided this approach because there are
some small changes necessary to get zstd to build, and I would
want to thoroughly re-test for performance, since that is slightly
changing the code in every function in zstd. It seems like a
trivial change, but some functions are pretty sensitive to small
changes. However, I think it is a valid approach that I would
like to see upstream take, so I've opened Issue #2868 to attempt
this upstream.

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/
[2] facebook/zstd#2868

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
buzzcut-s pushed a commit to buzzcut-s/kernel-x86-5.15 that referenced this pull request Nov 18, 2021
@terrelln @buzzcut-s
lib: zstd: Fix unused variable warning
c6fe233 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
cyberknight777 pushed a commit to Neternels/android_kernel_xiaomi_sunny that referenced this pull request Nov 18, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
e94064c 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
cyberknight777 pushed a commit to Neternels/android_kernel_xiaomi_sunny that referenced this pull request Nov 18, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
d5fc07c 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
cyberknight777 pushed a commit to cyberknight777/dragonheart_kernel_oneplus_sm8150 that referenced this pull request Nov 18, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
d89d974 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
cyberknight777 pushed a commit to cyberknight777/dragonheart_kernel_oneplus_sm8150 that referenced this pull request Nov 18, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
c524dc2 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
cyberknight777 pushed a commit to Neternels/android_kernel_xiaomi_sunny that referenced this pull request Nov 18, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
0587787 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
Forenche pushed a commit to stormbreaker-project/kernel_xiaomi_surya that referenced this pull request Nov 18, 2021
@terrelln @Forenche
BACKPORT: lib: zstd: Fix unused variable warning
cc27907 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
Signed-off-by: Forenche <prahul2003@gmail.com>
cyberknight777 pushed a commit to Neternels/android_kernel_xiaomi_sunny that referenced this pull request Nov 18, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
86dd4e9 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
cyberknight777 pushed a commit to cyberknight777/dragonheart_kernel_oneplus_sm8150 that referenced this pull request Nov 18, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
41543d2 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
cyberknight777 pushed a commit to Neternels/android_kernel_realme_rmx2020 that referenced this pull request Nov 18, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
c46a775 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
cyberknight777 pushed a commit to stormbreaker-project/kernel_xiaomi_surya that referenced this pull request Nov 18, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
a11faaf 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
Signed-off-by: Forenche <prahul2003@gmail.com>
cyberknight777 pushed a commit to cyberknight777/dragonheart_kernel_oneplus_sm8150 that referenced this pull request Nov 18, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
6ff01e4 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
cyberknight777 pushed a commit to stormbreaker-project/kernel_xiaomi_surya that referenced this pull request Nov 18, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
e330b4f 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
cyberknight777 pushed a commit to Neternels/android_kernel_xiaomi_sunny that referenced this pull request Nov 18, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
7cb5c9c 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
cyberknight777 pushed a commit to Neternels/android_kernel_realme_rmx2020 that referenced this pull request Nov 18, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
519759a 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
terrelln added a commit to terrelln/linux that referenced this pull request Nov 18, 2021
@terrelln
lib: zstd: Fix unused variable warning
ae8d67b 
The variable `litLengthSum` is only used by an `assert()`, so when
asserts are disabled the compiler doesn't see any usage and warns.

This issue is already fixed upstream by PR #2838 [0]. It was reported
by the Kernel test robot in [1].

Another approach would be to change zstd's disabled `assert()`
definition to use the argument in a disabled branch, instead of
ignoring the argument. I've avoided this approach because there are
some small changes necessary to get zstd to build, and I would
want to thoroughly re-test for performance, since that is slightly
changing the code in every function in zstd. It seems like a
trivial change, but some functions are pretty sensitive to small
changes. However, I think it is a valid approach that I would
like to see upstream take, so I've opened Issue #2868 to attempt
this upstream.

Lastly, I've chosen not to use __maybe_unused because all code
in lib/zstd/ must eventually be upstreamed. Upstream zstd can't
use __maybe_unused because it isn't portable across all compilers.

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/
[2] facebook/zstd#2868

Link: https://lore.kernel.org/r/20211117014949.1169186-2-nickrterrell@gmail.com/
Link: https://lore.kernel.org/r/20211117201459.1194876-2-nickrterrell@gmail.com/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
Forenche pushed a commit to stormbreaker-project/kernel_xiaomi_surya that referenced this pull request Nov 19, 2021
@terrelln @Forenche
BACKPORT: lib: zstd: Fix unused variable warning
7150004 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
Signed-off-by: Forenche <prahul2003@gmail.com>
Forenche pushed a commit to stormbreaker-project/kernel_xiaomi_surya that referenced this pull request Nov 19, 2021
@terrelln @Forenche
BACKPORT: lib: zstd: Fix unused variable warning
2bc0b2b 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
cyberknight777 pushed a commit to Neternels/android_kernel_realme_rmx2020 that referenced this pull request Nov 19, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
2fa2fef 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
cyberknight777 pushed a commit to Neternels/android_kernel_realme_rmx2020 that referenced this pull request Nov 19, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
9713f39 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
cyberknight777 pushed a commit to Neternels/android_kernel_realme_rmx2020 that referenced this pull request Nov 19, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
2f87ef9 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
cyberknight777 pushed a commit to Neternels/android_kernel_realme_rmx2020 that referenced this pull request Nov 19, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
0c61b81 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
cyberknight777 pushed a commit to Neternels/android_kernel_xiaomi_sunny that referenced this pull request Nov 21, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
d28af80 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
Forenche pushed a commit to stormbreaker-project/kernel_xiaomi_surya that referenced this pull request Nov 23, 2021
@terrelln @Forenche
BACKPORT: lib: zstd: Fix unused variable warning
b052ce5 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
javashin pushed a commit to MoonBase-Project/android_kernel_xiaomi_vayu that referenced this pull request Nov 26, 2021
@terrelln @javashin
BACKPORT: lib: zstd: Fix unused variable warning
9b24064 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
Signed-off-by: Carlos Jimenez (JavaShin-X) <javashin1986@gmail.com>
TheVoyager0777 pushed a commit to TheVoyager0777/Kernel_Xiaomi_SM8150_R that referenced this pull request Nov 29, 2021
@terrelln @TheVoyager0777
BACKPORT: lib: zstd: Fix unused variable warning
3f6efac 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
javashin pushed a commit to javashin/android_kernel_xiaomi_atoll that referenced this pull request Nov 29, 2021
@terrelln @javashin
BACKPORT: lib: zstd: Fix unused variable warning
bf1a30d 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
Signed-off-by: Carlos Jimenez (JavaShin-X) <javashin1986@gmail.com>
javashin pushed a commit to MiBengal-Development/android_kernel_xiaomi_bengal that referenced this pull request Dec 1, 2021
@terrelln @javashin
BACKPORT: lib: zstd: Fix unused variable warning
bc2dfed 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
Signed-off-by: Carlos Jimenez (JavaShin-X) <javashin1986@gmail.com>
Forenche pushed a commit to stormbreaker-project/kernel_xiaomi_surya that referenced this pull request Dec 2, 2021
@terrelln @Forenche
BACKPORT: lib: zstd: Fix unused variable warning
a93b32a 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
Signed-off-by: Forenche <prahul2003@gmail.com>
ElectroPerf pushed a commit to Atom-X-Devs/android_kernel_asus_sdm660 that referenced this pull request Dec 5, 2021
@terrelln @ElectroPerf
BACKPORT: lib: zstd: Fix unused variable warning
35dbbcc 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Change-Id: I68acd04fc709a97ffb65f7f87ffc28d454d354d9
[@ElectroPerf - Backport to 4.19]
Signed-off-by: Kunmun <kunmun.devroms@gmail.com>
Tashar02 pushed a commit to Atom-X-Devs/scarlet_xiaomi_sdm660 that referenced this pull request Dec 5, 2021
@terrelln @Tashar02
BACKPORT: lib: zstd: Fix unused variable warning
ab739a8 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Change-Id: I68acd04fc709a97ffb65f7f87ffc28d454d354d9
[@ElectroPerf - Backport to 4.19]
Signed-off-by: Kunmun <kunmun.devroms@gmail.com>
Signed-off-by: Tashfin Shakeer Rhythm <tashfinshakeerrhythm@gmail.com>
cyberknight777 pushed a commit to Neternels/android_kernel_realme_rmx2020 that referenced this pull request Dec 6, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
f742ba7 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
javashin pushed a commit to javashin/android_kernel_xiaomi_bengal that referenced this pull request Dec 6, 2021
@terrelln @javashin
BACKPORT: lib: zstd: Fix unused variable warning
402aaa6 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
Signed-off-by: Carlos Jimenez (JavaShin-X) <javashin1986@gmail.com>
ElectroPerf pushed a commit to Atom-X-Devs/android_kernel_asus_sdm660 that referenced this pull request Dec 7, 2021
@terrelln @ElectroPerf
BACKPORT: lib: zstd: Fix unused variable warning
9e3adc8 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Change-Id: I68acd04fc709a97ffb65f7f87ffc28d454d354d9
[@ElectroPerf - Backport to 4.19]
Signed-off-by: Kunmun <kunmun.devroms@gmail.com>
ElectroPerf pushed a commit to Atom-X-Devs/android_kernel_asus_sdm660 that referenced this pull request Dec 7, 2021
@terrelln @ElectroPerf
BACKPORT: lib: zstd: Fix unused variable warning
4a5d3c9 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Change-Id: I68acd04fc709a97ffb65f7f87ffc28d454d354d9
[@ElectroPerf - Backport to 4.19]
Signed-off-by: Kunmun <kunmun.devroms@gmail.com>
ElectroPerf pushed a commit to Atom-X-Devs/android_kernel_asus_sdm660 that referenced this pull request Dec 8, 2021
@terrelln @ElectroPerf
BACKPORT: lib: zstd: Fix unused variable warning
acaae12 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Change-Id: I68acd04fc709a97ffb65f7f87ffc28d454d354d9
[@ElectroPerf - Backport to 4.19]
Signed-off-by: Kunmun <kunmun.devroms@gmail.com>
ElectroPerf pushed a commit to Atom-X-Devs/android_kernel_asus_sdm660 that referenced this pull request Dec 8, 2021
@terrelln @ElectroPerf
BACKPORT: lib: zstd: Fix unused variable warning
f26ec72 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Change-Id: I68acd04fc709a97ffb65f7f87ffc28d454d354d9
[@ElectroPerf - Backport to 4.19]
Signed-off-by: Kunmun <kunmun.devroms@gmail.com>
ElectroPerf pushed a commit to Atom-X-Devs/android_kernel_asus_sdm660 that referenced this pull request Dec 9, 2021
@terrelln @ElectroPerf
BACKPORT: lib: zstd: Fix unused variable warning
673963b 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Change-Id: I68acd04fc709a97ffb65f7f87ffc28d454d354d9
[@ElectroPerf - Backport to 4.19]
Signed-off-by: Kunmun <kunmun.devroms@gmail.com>
cyberknight777 pushed a commit to Neternels/NetHunter-Ginkgo that referenced this pull request Dec 11, 2021
@terrelln @cyberknight777
BACKPORT: lib: zstd: Fix unused variable warning
1d8ea25 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
[cyberknight777: backport to 4.14]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
Tashar02 pushed a commit to Atom-X-Devs/scarlet_xiaomi_sdm660 that referenced this pull request Dec 11, 2021
@terrelln @Tashar02
BACKPORT: lib: zstd: Fix unused variable warning
557bd7e 
Backport the fix from upstream PR #2838 [0]. Found by the Kernel test
robot in [1].

[0] facebook/zstd#2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/

Reported-by: kernel test robot <lkp@intel.com>
Change-Id: I68acd04fc709a97ffb65f7f87ffc28d454d354d9
[@ElectroPerf - Backport to 4.19]
Signed-off-by: Kunmun <kunmun.devroms@gmail.com>
Signed-off-by: Tashfin Shakeer Rhythm <tashfinshakeerrhythm@gmail.com>
@clalancette clalancette mentioned this pull request Apr 18, 2024
Merged
@uwu-gl uwu-gl mentioned this pull request Jun 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

+1 more reviewer

@senhuang42 senhuang42 senhuang42 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@binhdvo @Cyan4973 @senhuang42 @facebook-github-bot