Merged
Conversation
Contributor
Author
|
So the aarch64 compiler error is still there. But, it turns out that our CircleCI tests are failing silently. Likely because they don't have a trailing |
terrelln
force-pushed
the
issue-2785
branch
2 times, most recently
from
77caec4 to
58ef167
Compare
terrelln
changed the title
terrelln
force-pushed
the
issue-2785
branch
3 times, most recently
from
6bca589 to
91f5891
Compare
short-tests-0 were silently failing. I think because of the && make clean construction. Switch to ; instead. Also fix all the test failures that were exposed. `make all` is failing on CircleCI because it is missing Docker. Move that test to GitHub actions, and switch the pedantic CircleCI test to `make allmost`.
Cyan4973
approved these changes
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
short-tests-0 were silently failing. I think because of the
&& make cleanconstruction. Switch to;instead.Fix the reported build errors.