Skip to content

[trace] Add aarch64 to supported architectures for zstd_trace#3054

Merged
Cyan4973 merged 1 commit intofacebook:devfrom
ooosssososos:patch-1
Feb 11, 2022
Merged

[trace] Add aarch64 to supported architectures for zstd_trace#3054
Cyan4973 merged 1 commit intofacebook:devfrom
ooosssososos:patch-1

Conversation

@ooosssososos
Copy link
Contributor

Arm Toolchain should support weak symbols

Arm Toolchain should support weak symbols
@facebook-github-bot
Copy link

Hi @ooosssososos!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@ooosssososos
Copy link
Contributor Author

Any updates on this? Seems to be failing checks for windows that are unrelated to change?

@terrelln
Copy link
Contributor

This looks good to me!

I've just re-run the jobs, which should be fixed now. If they're still failing, please rebase onto the latest dev and push, and the tests should pass.

@Cyan4973 Cyan4973 merged commit 3202c75 into facebook:dev Feb 11, 2022
@Cyan4973 Cyan4973 mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants