Skip to content

Debug Windows CI failures#3061

Merged
embg merged 1 commit intofacebook:devfrom
embg:debug_ci_windows
Feb 9, 2022
Merged

Debug Windows CI failures#3061
embg merged 1 commit intofacebook:devfrom
embg:debug_ci_windows

Conversation

@embg
Copy link
Contributor

@embg embg commented Feb 9, 2022

This draft PR will allow me to ssh into a windows CI machine so I can debug the recent windows CI failures. For some reason the tests are passing on my zstd fork, so I have to create a PR on the main repo.

@embg embg force-pushed the debug_ci_windows branch from 0d96618 to 9caabc0 Compare February 9, 2022 20:46
@embg
Copy link
Contributor Author

embg commented Feb 9, 2022

I was not able to ssh into a windows CI machine, but comparing logs here vs my own fork did reveal the problem. For some reason, CI on my fork resolved windows-latest to windows-2019 while CI on the main repo resolved it to windows-2022. This explains why I could not reproduce the failures on my own fork. I replaced all instances of windows-latest with windows-2019 in our workflows and it fixed the broken tests.

For discussion: should we add tests for Visual Studio 2022? Currently we have tests covering 2019 and 2015. We could remove the 2015 tests and replace them with tests for 2022 (or keep 2015 and just add 2022). I can put up a separate PR with that change (so we can merge this ASAP to unbreak CI).

Edit: created an issue for VS 2022 discussion #3064

@embg embg marked this pull request as ready for review February 9, 2022 21:12
@embg embg merged commit caf2fa1 into facebook:dev Feb 9, 2022
@paolobarbolini
Copy link

For discussion: should we add tests for Visual Studio 2022? Currently we have tests covering 2019 and 2015. We could remove the 2015 tests and replace them with tests for 2022 (or keep 2015 and just add 2022). I can put up a separate PR with that change (so we can merge this ASAP to unbreak CI).

I think this would make it easier to get seanmonstar/reqwest#1464 through

@embg embg mentioned this pull request Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants