More checks on numeric input for zstd CLI#3078
Closed
IAL32 wants to merge 3 commits intofacebook:devfrom
IAL32:3070-zstd-cli-memory-bogus-values
Closed
More checks on numeric input for zstd CLI#3078IAL32 wants to merge 3 commits intofacebook:devfrom IAL32:3070-zstd-cli-memory-bogus-values
zstd CLI#3078IAL32 wants to merge 3 commits intofacebook:devfrom
IAL32:3070-zstd-cli-memory-bogus-values
Conversation
Changed read method instead
Contributor
|
Issue fixed in #3268 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3070
zstdCLI--memory,--memlimitand--memlimit-decompressto only be used with=at the end of the parametermemLimittype changed fromunsignedtosize_tto be more in line withsrcSizeHint, as both refer to memory values