Skip to content

More checks on numeric input for zstd CLI#3078

Closed
IAL32 wants to merge 3 commits intofacebook:devfrom
IAL32:3070-zstd-cli-memory-bogus-values
Closed

More checks on numeric input for zstd CLI#3078
IAL32 wants to merge 3 commits intofacebook:devfrom
IAL32:3070-zstd-cli-memory-bogus-values

Conversation

@IAL32
Copy link
Contributor

@IAL32 IAL32 commented Mar 1, 2022

Closes #3070

  • Added check for a possible invalid combination of numeric values in zstd CLI
  • Does not perfectly cover all invalid combinations, but it's better than before
  • Added some tests
  • Slightly changes --memory, --memlimit and --memlimit-decompress to only be used with = at the end of the parameter
  • memLimit type changed from unsigned to size_t to be more in line with srcSizeHint, as both refer to memory values

@Cyan4973
Copy link
Contributor

Issue fixed in #3268

@Cyan4973 Cyan4973 closed this Dec 12, 2022
@IAL32 IAL32 deleted the 3070-zstd-cli-memory-bogus-values branch December 12, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zstd CLI accepts bogus values for numeric parameters

3 participants