[AIX] Fix Compiler Flags and Bugs on AIX to Pass All Tests#3219
Merged
terrelln merged 5 commits intofacebook:devfrom Jul 29, 2022
Merged
[AIX] Fix Compiler Flags and Bugs on AIX to Pass All Tests#3219terrelln merged 5 commits intofacebook:devfrom
terrelln merged 5 commits intofacebook:devfrom
Conversation
added 3 commits
July 29, 2022 13:00
terrelln
approved these changes
Jul 29, 2022
Contributor
terrelln
left a comment
terrelln
left a comment
There was a problem hiding this comment.
Thanks for the PR @qiongsiwu! Looks good to me!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes:
-scompiler flag that is no longer supported by newer versions ofclang. It is replaced by-Wl,-s.mallocof size zero returns 0 on AIX, causing thedict-builder/no-inputs.shtest case to fail.