Merged
Conversation
Tachi107
force-pushed
the
pkg-config-ci
branch
from
1b258fd to
7a62193
Compare
As mentioned in facebook#3252 (comment) , this patch adds a CI job that builds and installs libzstd on the job runner, and then compiles a sample binary linking against the installed library; the needed build flags are passed by invoking pkg-config.
Tachi107
force-pushed
the
pkg-config-ci
branch
from
7a62193 to
966ac9d
Compare
Tachi107
commented
Sep 20, 2022
| - name: Install dependencies | ||
| run: | | ||
| apt -y update | ||
| apt -y install --no-install-recommends gcc libc6-dev make pkg-config |
Contributor
Author
There was a problem hiding this comment.
I've added --no-install-recommends just to speed up the job by a few seconds.
It skips the installation of things like manpages that are not needed on a headless build server.
Cyan4973
approved these changes
Sep 22, 2022
Contributor
Contributor
Author
|
Glad to help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #3252 (comment), this patch adds a CI job that builds and installs libzstd on the job runner, and then compiles a sample binary linking against the installed library; the needed build flags are passed by invoking pkg-config.