Skip to content

meson: get version up front#3327

Merged
Cyan4973 merged 1 commit intofacebook:devfrom
eli-schwartz:meson-version-simplify
Dec 1, 2022
Merged

meson: get version up front#3327
Cyan4973 merged 1 commit intofacebook:devfrom
eli-schwartz:meson-version-simplify

Conversation

@eli-schwartz
Copy link
Contributor

Run the scraper command to establish the project version immediately, rather than wait for the build to be configured. This simplifies the code and ensures that project introspection works correctly.

Run the scraper command to establish the project version immediately,
rather than wait for the build to be configured. This simplifies the
code and ensures that project introspection works correctly.
@Cyan4973
Copy link
Contributor

Cyan4973 commented Dec 1, 2022

I like it. It indeed feels more logical.

@Cyan4973 Cyan4973 merged commit e873335 into facebook:dev Dec 1, 2022
@eli-schwartz eli-schwartz deleted the meson-version-simplify branch December 1, 2022 23:45
@Cyan4973 Cyan4973 mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants