Seekable format empty string#3343
Closed
daniellerozenblit wants to merge 3 commits intofacebook:devfrom
Closed
Conversation
seekable_format no header when compressing empty string to stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a followup to a previous PR by @yhoogstrate. The goal of the previous PR was to fix a small bug in
seekable_formatthat led to the omission of the ZSTD MAGIC when compressing an empty string.I have validated the bug fix with the test case provided, but have created this PR to fix some minor issues (forgetting to free malloc'd memory in the test case).
Note that, upon further investigation, it seems that this issue occured whenever
ZSTD_inBuffer.size == 0, rather than explicitly for an empty string (NULL first char). For example, if we set the size of inBuffer to 255, set the first char toNULL, and setZSTD_inBuffer.size == sizeof(inBuffer), the ZSTD MAGIC was present. On the other hand, if we setZSTD_inBuffer.size == strlen(inBuffer), the ZSTD MAGIC was omitted.