Seekable format empty string#3346
Conversation
seekable_format no header when compressing empty string to stream
|
This looks good to me once CI passes! Only question is do you know if the seekable format tests run in CI? |
Good point, But ... looking at the list of tests on Github Actions, edit : I can't find any trace of edit 2: Actually, So that's fine ! |
|
wow thanks @daniellerozenblit to carry this forwards ! Good to see the test works and the contrib tests are included in the CI. Sorry I missed the free after malloc 😳 |
This PR is a followup to a previous PR by @yhoogstrate. The goal of the previous PR was to fix a small bug in
seekable_formatthat led to the omission of the ZSTD MAGIC when compressing an empty string.I have validated the bug fix with the test case provided, but have created this PR to fix some minor issues (forgetting to free malloc'd memory in the test case).