[decompress] Fix nullptr addition & improve fuzzer#3356
Merged
terrelln merged 1 commit intofacebook:devfrom Dec 15, 2022
Merged
[decompress] Fix nullptr addition & improve fuzzer#3356terrelln merged 1 commit intofacebook:devfrom
terrelln merged 1 commit intofacebook:devfrom
Conversation
Fix an instance of `NULL + 0` in `ZSTD_decompressStream()`. Also, improve our `stream_decompress` fuzzer to pass `NULL` in/out buffers to `ZSTD_decompressStream()`, and fix 2 issues that were immediately surfaced. Fixes facebook#3351
Cyan4973
approved these changes
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an instance of
NULL + 0inZSTD_decompressStream(). Also, improve ourstream_decompressfuzzer to passNULLin/out buffers toZSTD_decompressStream(), and fix 2 issues that were immediately surfaced.The
stream_decompressfuzzer now catches this bug when the relevant UBSAN warning is enabled.I scanned through
ZSTD_decompressStream()and this seems to be the only offending pointer arithmetic.Fixes #3351