Conversation
fixed an overflow in an intermediate result on 32-bit platform. Checked that the new test catch this bug in 32-bit mode.
terrelln
approved these changes
Dec 16, 2022
for environments with stringent compilation warnings.
Cyan4973
force-pushed
the
decompressBound
branch
from
f680d39 to
2f4238e
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a complement to #3362 , and finalize fixes for #3323 .
There are additional unit tests to ensure behavior of
ZSTD_decompressBound(),including a new "overflow" test which attempts to overflow intermediate results on 32-bit systems
(
ZSTD_decompressBound()return type isunsigned long longwhich is >= 64-bit , therefore only intermediate calculation results feature overflow risks).Fixed the detected overflow.