Try to build the contrib directory in Windows CI#3375
Closed
eli-schwartz wants to merge 2 commits intofacebook:devfrom
Closed
Try to build the contrib directory in Windows CI#3375eli-schwartz wants to merge 2 commits intofacebook:devfrom
eli-schwartz wants to merge 2 commits intofacebook:devfrom
Conversation
Contributor
|
Thanks for the PR! These all look like easy fixes. I can stack a PR on top of this with the fixes and merge that. |
terrelln
added a commit
to terrelln/zstd
that referenced
this pull request
Dec 19, 2022
* `#include <algorithm>` * Fix conversion warnings * Assert that windowLog <= 23, which is currently always the case. This could be loosened, but we aren't looking to add new functionality. Fixes on top of PR facebook#3375 by @eli-schwartz, which added Windows CI for contrib & programs.
terrelln
added a commit
to terrelln/zstd
that referenced
this pull request
Dec 19, 2022
* Add `Portability.h` to fix min/max issues. * Fix conversion warnings * Assert that windowLog <= 23, which is currently always the case. This could be loosened, but we aren't looking to add new functionality. Fixes on top of PR facebook#3375 by @eli-schwartz, which added Windows CI for contrib & programs.
Contributor
Author
|
Nice, looks good. :) |
terrelln
added a commit
to terrelln/zstd
that referenced
this pull request
Dec 19, 2022
* Add `Portability.h` to fix min/max issues. * Fix conversion warnings * Assert that windowLog <= 23, which is currently always the case. This could be loosened, but we aren't looking to add new functionality. Fixes on top of PR facebook#3375 by @eli-schwartz, which added Windows CI for contrib & programs.
terrelln
added a commit
that referenced
this pull request
Dec 19, 2022
* Add `Portability.h` to fix min/max issues. * Fix conversion warnings * Assert that windowLog <= 23, which is currently always the case. This could be loosened, but we aren't looking to add new functionality. Fixes on top of PR #3375 by @eli-schwartz, which added Windows CI for contrib & programs.
Contributor
|
Merged as part of #3380. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just going to fail. PR submitted as a demonstration. The logs look like this: