Fix patch-from speed optimization#3556
Merged
daniellerozenblit merged 1 commit intofacebook:devfrom Mar 21, 2023
Merged
Conversation
Contributor
|
The code looks good! How did you test that it doesn't regression compression speed? E.g. that this fix is still achieving the speedup we were aiming for. |
Contributor
Author
I ran some benchmarks for the lower compression levels (levels 5, 7, 9, 12, 15) and speeds were comparable to my previous benchmarks. There was also no change in the regression tests. |
terrelln
approved these changes
Mar 21, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a followup to a previous patch-from speed optimization (#3545).
It ensures that the window size takes into account the full, un-truncated dictionary, in the normal matchfinders.