fuzz: Fix FUZZ_malloc_rand() to return non-NULL for zero-size allocations#4403
Merged
Cyan4973 merged 1 commit intofacebook:devfrom Jun 9, 2025
Merged
fuzz: Fix FUZZ_malloc_rand() to return non-NULL for zero-size allocations#4403Cyan4973 merged 1 commit intofacebook:devfrom
Cyan4973 merged 1 commit intofacebook:devfrom
Conversation
dloidolt
force-pushed
the
fix_FUZZ_malloc_rand
branch
from
30fa5b0 to
29a65c6
Compare
…ions The FUZZ_malloc_rand() function was incorrectly always returning NULL for zero-size allocations. The random offset generated by FUZZ_dataProducer_int32Range() was not being added to the pointer variable, causing the function to always return (void *)0.
dloidolt
force-pushed
the
fix_FUZZ_malloc_rand
branch
from
29a65c6 to
4be08ba
Compare
Contributor
|
I would really like to understand the perspective of @daniellerozenblit and @terrelln on this test, |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
FUZZ_malloc_randhelper function introduced in fcaf06d.The FUZZ_malloc_rand() function was incorrectly always returning NULL for zero-size allocations. The random offset generated by FUZZ_dataProducer_int32Range() was not being added to the pointer variable, causing the function to always return (void *)0.