This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Added timeout parameter for API objects #181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 for this change. I've personally been setting the default socket timeout to 5 seconds but being able to set a timeout on a specific InstagramAPI instance would be solid. |
|
👍 please, merge this for next release |
This was referenced Feb 27, 2017
Open
added 4 commits
May 31, 2017 09:29
This is a rebased version of Kevin's original fix from here: https://github.com/facebookarchive/python-instagram/pull/195/files
By default there is no timeout on requests to the InstagramAPI. This can cause unexpected behavior if a system is not anticipating a request to block indefinitely. This patch stops short of imposing a default timeout value, but does expose the ability to specify a timeout value upon creating an api object. The README has also been updated.
This includes a hack to get around urlencoding unicode tags.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default there is no timeout on requests to the InstagramAPI. This can
cause unexpected behavior if a system is not anticipating a request to
block indefinitely.
This patch stops short of imposing a default timeout value, but does
expose the ability to specify a timeout value upon creating an api object.
The README has also been updated.