This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Fixes #18 - text inside tags shouldn't be evaluated as code #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Actually this isn't quite there yet - need to fix a few more things. |
Contributor
Author
|
I think this should work pretty well now. |
Contributor
Author
|
Eh, still might be able to use a little work for edge cases. |
Contributor
|
@tgriesser cool, are there any updates on this? I'm curious to hear your thoughts on #28. |
|
Bumping this, really like to see this merged. |
Contributor
Author
|
Ah yeah I'll see if I can take another look |
There was a problem hiding this comment.
It seems as if you're removing the highlighting of tag attribute names, without adding it back, is this intentional?
|
👍 Would also like to see this merged. |
jgebhardt
added a commit
that referenced
this pull request
Feb 14, 2015
Fixes #18 - text inside tags shouldn't be evaluated as code
Contributor
|
Thanks! Sorry for the delay! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.