Split header and data size in encoding size estimation #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
…ator#279) Summary: Pull Request resolved: facebookincubator#279 Split header and data size in encoding size estimation, so that the read factor can only be applied to the compressible data. Current implementation give funky estimates for small sized data. Differential Revision: D84458948
sdruzkin
force-pushed
the
export-D84458948
branch
from
74840cc to
eb5b38a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Split header and data size in encoding size estimation so that the read factor can only be applied to the compressible data. Current implementation give funky estimates for small sized data.
Differential Revision: D84458948