Skip to content

Remove C-style array from SlidingWindowMapFieldReader #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdruzkin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove C-style array from SlidingWindowMapFieldReader #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dwio/nimble/velox/FieldReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1422,8 +1422,9 @@ class SlidingWindowMapFieldReader final : public FieldReader {

bool hasNulls = nonNullCount != rowCount;
// Read the lengths
uint32_t lengthBuffer[nonNullCount];
lengthsDecoder_->next(nonNullCount, lengthBuffer);
std::vector<uint32_t> lengthBuffer;
lengthBuffer.resize(nonNullCount);
lengthsDecoder_->next(nonNullCount, lengthBuffer.data());

// Convert the offsets and lengths to a list of unique offsets and lengths
// and update the indices to be 0-based indices
Expand Down
Loading