Fix GetRawDatasize Test Util for Nullable Encoding #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@macvincent has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88113894. |
Summary: D87964917 made a change to a CMakeLists.txt file that broke OSS builds. This diff fixes that. Differential Revision: D88117968
…#339) Summary: The test util used to calculate encoding sizes in NimbleDump and VeloxWriter tests only includes the size of the nulls bits for nullable encoded data. This is different from how sizes are nullable content stream sizes are calculated in the rest of our code base and introduced flakiness to a VeloxWriter test. This diff fixes that. Differential Revision: D88113894
macvincent
force-pushed
the
export-D88113894
branch
from
6eb6738 to
2aac633
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Dec 2, 2025
…#339) Summary: The test util used to calculate encoding sizes in NimbleDump and VeloxWriter tests only includes the size of the nulls bits for nullable encoded data. This is different from how sizes are nullable content stream sizes are calculated in the rest of our code base and introduced flakiness to a VeloxWriter test. This diff fixes that. Differential Revision: D88113894
xiaoxmeng
approved these changes
Dec 2, 2025
|
This pull request has been merged in 3c54a97. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The test util used to calculate encoding sizes in NimbleDump and VeloxWriter tests only includes the size of the nulls bits for nullable encoded data. This is different from how sizes are nullable content stream sizes are calculated in the rest of our code base and introduced flakiness to a VeloxWriter test. This diff fixes that.
Differential Revision: D88113894