Support Per Stream String Buffers in Stream Data #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@macvincent has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89933055. |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Dec 30, 2025
Summary: Pull Request resolved: facebookincubator#391 Differential Revision: D89933055
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Dec 30, 2025
Summary: Pull Request resolved: facebookincubator#391 Differential Revision: D89933055
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Dec 30, 2025
Summary: Adds per-stream string buffer support to Nimble's StreamData infrastructure. Previously, string data buffers were managed externally, but now each MutableStreamData instance can own its own Buffer for string content, enabling better memory isolation and lifecycle management with chunking. Differential Revision: D89933055
macvincent
force-pushed
the
export-D89933055
branch
from
f931c29 to
a300655
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Dec 30, 2025
Summary: Adds per-stream string buffer support to Nimble's StreamData infrastructure. Previously, string data buffers were managed externally, but now each MutableStreamData instance can own its own Buffer for string content, enabling better memory isolation and lifecycle management with chunking. Differential Revision: D89933055
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Dec 30, 2025
Summary: Adds per-stream string buffer support to Nimble's StreamData infrastructure. Previously, string data buffers were managed externally, but now each MutableStreamData instance can own its own Buffer for string content, enabling better memory isolation and lifecycle management with chunking. Differential Revision: D89933055
macvincent
force-pushed
the
export-D89933055
branch
from
a300655 to
9d372a9
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jan 5, 2026
Summary: Adds per-stream string buffer support to Nimble's StreamData infrastructure. Previously, string data buffers were managed externally, but now each MutableStreamData instance can own its own Buffer for string content, enabling better memory isolation and lifecycle management with chunking. Differential Revision: D89933055
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jan 5, 2026
Summary: Adds per-stream string buffer support to Nimble's StreamData infrastructure. Previously, string data buffers were managed externally, but now each MutableStreamData instance can own its own Buffer for string content, enabling better memory isolation and lifecycle management with chunking. Differential Revision: D89933055
macvincent
force-pushed
the
export-D89933055
branch
from
9d372a9 to
3832c80
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jan 6, 2026
Summary: Adds per-stream string buffer support to Nimble's StreamData infrastructure. Previously, string data buffers were managed externally, but now each MutableStreamData instance can own its own Buffer for string content, enabling better memory isolation and lifecycle management with chunking. Differential Revision: D89933055
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jan 6, 2026
Summary: Adds per-stream string buffer support to Nimble's StreamData infrastructure. Previously, string data buffers were managed externally, but now each MutableStreamData instance can own its own Buffer for string content, enabling better memory isolation and lifecycle management with chunking. Differential Revision: D89933055
macvincent
force-pushed
the
export-D89933055
branch
from
3832c80 to
7420b12
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jan 6, 2026
Summary: Adds per-stream string buffer support to Nimble's StreamData infrastructure. Previously, string data buffers were managed externally, but now each MutableStreamData instance can own its own Buffer for string content, enabling better memory isolation and lifecycle management with chunking. Differential Revision: D89933055
macvincent
force-pushed
the
export-D89933055
branch
from
7420b12 to
2aa9df8
Compare
Summary: Adds per-stream string buffer support to Nimble's StreamData infrastructure. Previously, string data buffers were managed externally. This diff introduces a `StringBuffer` class that gives each `MutableStreamData` instance ownership of its string content. By storing the raw character data and lengths directly within the stream, the chunker can now safely compact strings during compact() operations without relying on external buffer lifetimes. This enables incremental memory reclamation as chunks are written, which is particularly beneficial for string-heavy tables where the shared buffer would otherwise grow unbounded until stripe flush. Differential Revision: D89933055
macvincent
force-pushed
the
export-D89933055
branch
from
2aa9df8 to
c6588bb
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jan 6, 2026
Summary: Adds per-stream string buffer support to Nimble's StreamData infrastructure. Previously, string data buffers were managed externally. This diff introduces a `StringBuffer` class that gives each `MutableStreamData` instance ownership of its string content. By storing the raw character data and lengths directly within the stream, the chunker can now safely compact strings during compact() operations without relying on external buffer lifetimes. This enables incremental memory reclamation as chunks are written, which is particularly beneficial for string-heavy tables where the shared buffer would otherwise grow unbounded until stripe flush. Differential Revision: D89933055
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jan 6, 2026
Summary: Adds per-stream string buffer support to Nimble's StreamData infrastructure. Previously, string data buffers were managed externally. This diff introduces a `StringBuffer` class that gives each `MutableStreamData` instance ownership of its string content. By storing the raw character data and lengths directly within the stream, the chunker can now safely compact strings during compact() operations without relying on external buffer lifetimes. This enables incremental memory reclamation as chunks are written, which is particularly beneficial for string-heavy tables where the shared buffer would otherwise grow unbounded until stripe flush. Differential Revision: D89933055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D89933055