This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Remove local_variables from on_phase_start#416
Closed
vreis wants to merge 5 commits intofacebookresearch:masterfrom
Closed
Remove local_variables from on_phase_start#416vreis wants to merge 5 commits intofacebookresearch:masterfrom
vreis wants to merge 5 commits intofacebookresearch:masterfrom
Conversation
Summary: local_variables makes the code in train_step really hard to read. Killing it from all hooks will take time, so start from a single hook (on_step). Differential Revision: D20171981 fbshipit-source-id: 40da15e22a2abc129a77e37784fb99ec7e3f8e97
Differential Revision: D20170006 fbshipit-source-id: 9978286a536cfc8957bbeafcdc718b527b6b3392
Summary: This is part of a series of diffs to eliminate local_variables (see D20171981). Proceed remobing local_variables from on_start Differential Revision: D20178165 fbshipit-source-id: b26fcac59cf4f2741f0f65ee172e2a1336393cef
Differential Revision: D20178202 fbshipit-source-id: 8474f23c2f099bd5ef819e903c4a5c193883bf0a
Summary: This is part of a series of diffs to eliminate local_variables (see D20171981). Proceed removing local_variables from on_phase_start Differential Revision: D20178268 fbshipit-source-id: b00cbd57044633543846d0bf96c261de36f7a421
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D20178268 |
Contributor
|
This pull request has been merged in 0b2368e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is part of a series of diffs to eliminate local_variables (see D20171981).
Proceed removing local_variables from on_phase_start
Differential Revision: D20178268