This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Move use_gpu from ClassyTrainer to ClassificationTask#468
Closed
vreis wants to merge 1 commit intofacebookresearch:masterfrom
Closed
Move use_gpu from ClassyTrainer to ClassificationTask#468vreis wants to merge 1 commit intofacebookresearch:masterfrom
vreis wants to merge 1 commit intofacebookresearch:masterfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D20801017 |
vreis
added a commit
to vreis/ClassyVision-2
that referenced
this pull request
Apr 8, 2020
…ch#468) Summary: Pull Request resolved: facebookresearch#468 This is the first in a series of diffs to eliminate the ClassyTrainer abstraction. The only reason Trainer existed was to support elastic training, but PET v0.2 does not require changing out training loop. The plan is to move all attributes from ClassyTrainer into ClassificationTask. Start by moving use_gpu to the task. Differential Revision: D20801017 fbshipit-source-id: 46b3a3d032947bf7ffe9b90edc76280c5df63566
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D20801017 |
…ch#468) Summary: Pull Request resolved: facebookresearch#468 This is the first in a series of diffs to eliminate the ClassyTrainer abstraction. The only reason Trainer existed was to support elastic training, but PET v0.2 does not require changing out training loop. The plan is to move all attributes from ClassyTrainer into ClassificationTask. Start by moving use_gpu to the task. Reviewed By: mannatsingh Differential Revision: D20801017 fbshipit-source-id: d56bb330737a98a7ea7545d33da0ad0f21a0b6a1
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D20801017 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2020
Summary: Pull Request resolved: #468 This is the first in a series of diffs to eliminate the ClassyTrainer abstraction. The only reason Trainer existed was to support elastic training, but PET v0.2 does not require changing our training loop. The plan is to move all attributes from ClassyTrainer into ClassificationTask. Start by moving use_gpu to the task. Reviewed By: mannatsingh Differential Revision: D20801017 fbshipit-source-id: 90a8ab4c4a2407964c192f6ed905a74a4eb93e6d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is the first in a series of diffs to eliminate the ClassyTrainer abstraction. The only reason Trainer existed was to support elastic training, but PET v0.2 does not require changing out training loop. The plan is to move all attributes from ClassyTrainer into ClassificationTask.
Start by moving use_gpu to the task.
Differential Revision: D20801017