Catch backend transport errors in ProxyHandler (#584)#584
Open
SamirFarhat17 wants to merge 1 commit intofacebookresearch:v2-betafrom
Open
Catch backend transport errors in ProxyHandler (#584)#584SamirFarhat17 wants to merge 1 commit intofacebookresearch:v2-betafrom
SamirFarhat17 wants to merge 1 commit intofacebookresearch:v2-betafrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@SamirFarhat17 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101553391. |
meta-codesync
Bot
changed the title
SamirFarhat17
added a commit
to SamirFarhat17/DCPerf
that referenced
this pull request
Apr 21, 2026
Summary: Intercept TRANSPORT_READ_ERROR from the backend response source before it leaks to the downstream session. Without this, connection pool warmup causes noisy 'Application supplied internal error code ec=4103' warnings on every initial request batch. Now the proxy reads the response headers itself — if the backend connection errors, it returns a clean 502 instead of propagating the raw transport error downstream. Also modified BUCK to actually build the dcperf version of the foss_revproxy repo rather then the original internal version Reviewed By: YifanYuan3 Differential Revision: D101553391
SamirFarhat17
force-pushed
the
export-D101553391-to-v2-beta
branch
from
6dc47e9 to
26c5293
Compare
Summary: Pull Request resolved: facebookresearch#584 Intercept TRANSPORT_READ_ERROR from the backend response source before it leaks to the downstream session. Without this, connection pool warmup causes noisy 'Application supplied internal error code ec=4103' warnings on every initial request batch. Now the proxy reads the response headers itself — if the backend connection errors, it returns a clean 502 instead of propagating the raw transport error downstream. Also modified BUCK to actually build the dcperf version of the foss_revproxy repo rather then the original internal version Reviewed By: YifanYuan3 Differential Revision: D101553391
SamirFarhat17
force-pushed
the
export-D101553391-to-v2-beta
branch
from
26c5293 to
46c46ac
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
Apr 21, 2026
Summary: Pull Request resolved: #584 Intercept TRANSPORT_READ_ERROR from the backend response source before it leaks to the downstream session. Without this, connection pool warmup causes noisy 'Application supplied internal error code ec=4103' warnings on every initial request batch. Now the proxy reads the response headers itself — if the backend connection errors, it returns a clean 502 instead of propagating the raw transport error downstream. Also modified BUCK to actually build the dcperf version of the foss_revproxy repo rather then the original internal version Reviewed By: YifanYuan3 Differential Revision: D101553391 fbshipit-source-id: 0f29555bedc71336fd30a18f761b98cc4a92769f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Intercept TRANSPORT_READ_ERROR from the backend response source before it leaks to the downstream session. Without this, connection pool warmup causes noisy 'Application supplied internal error code ec=4103' warnings on every initial request batch.
Now the proxy reads the response headers itself — if the backend connection errors, it returns a clean 502 instead of propagating the raw transport error downstream.
Also modified BUCK to actually build the dcperf version of the foss_revproxy repo rather then the original internal version
Reviewed By: YifanYuan3
Differential Revision: D101553391