Skip to content

Upgrade dependencies & replace deprecated modules with modern alternatives#136

Merged
rohitgirdhar merged 8 commits intofacebookresearch:mainfrom
ahmedsaed:main
Sep 10, 2025
Merged

Upgrade dependencies & replace deprecated modules with modern alternatives#136
rohitgirdhar merged 8 commits intofacebookresearch:mainfrom
ahmedsaed:main

Conversation

@ahmedsaed
Copy link
Contributor

@ahmedsaed ahmedsaed commented Feb 25, 2025

This PR upgrades some project dependencies and replaces deprecated modules with their recommended alternatives.

Upgraded dependencies:

  • torch>=2.0.0
  • pytorchvideo to commit 6cdc9 (latest at the time of making the PR)
  • timm to latest

Replaced deprecated modules:

  • torchvision.transforms._transforms_video.NormalizeVideo with torchvision.transforms.Normalize

I have tested these changes in this colab notebook using the example provided in the README.md.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 25, 2025
@ajland
Copy link

ajland commented Apr 22, 2025

Fixed the issues I ran into with the current installation procedure. Just had to modify a couple of the import statements to reflect their current implementation. One of them was torchvision.transforms.functional_tensor (became torchvision.transforms.functional) within the torchvision package and the other was the same in two of imagebind's files (timm.layers became timm.modules.layers).

@ahmedsaed
Copy link
Contributor Author

Fixed the issues I ran into with the current installation procedure. Just had to modify a couple of the import statements to reflect their current implementation. One of them was torchvision.transforms.functional_tensor (became torchvision.transforms.functional) within the torchvision package and the other was the same in two of imagebind's files (timm.layers became timm.modules.layers).

I couldn't find any references to functional_tensor in the code. Can you provide more details? I don't believe the timm v1.0.15 has timm.modules.layers.

The provided changes in this PR works with the versions defined in requirements.txt. I have tested it in multiple experiments.

@ahmedsaed
Copy link
Contributor Author

In 7436d3a, I removed some deps from the requirements.txt as I can't seem to find any references or imports in the code. This should make the installation easier and faster.

@marblestation
Copy link

The current HEAD 3fcf5c9 does not work with modern dependencies. This PR makes ImageBind usable again for me (hopefully it will get merged), thanks @ahmedsaed!

@universome
Copy link

Any plans to merge it? The current version of ImageBind is broken anyway (for non-outdated versions of the dependencies)

@rohitgirdhar rohitgirdhar merged commit a3941d9 into facebookresearch:main Sep 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants