@final is only supported for python3.8#417
Closed
czxttkl wants to merge 1 commit intofacebookresearch:masterfrom
Closed
@final is only supported for python3.8#417czxttkl wants to merge 1 commit intofacebookresearch:masterfrom
czxttkl wants to merge 1 commit intofacebookresearch:masterfrom
Conversation
Summary: we need to import final from typing_extensions Reviewed By: MisterTea Differential Revision: D26993309 fbshipit-source-id: 6514eb4e353415aa57835790b7411c0daed68af1
|
This pull request was exported from Phabricator. Differential Revision: D26993309 |
|
This pull request has been merged in ab9ac76. |
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: we need to import final from typing_extensions
Reviewed By: MisterTea
Differential Revision: D26993309