Move functions related to create_df_from_replay_buffer under //reagent/#423
Closed
gji1 wants to merge 1 commit intofacebookresearch:masterfrom
Closed
Move functions related to create_df_from_replay_buffer under //reagent/#423gji1 wants to merge 1 commit intofacebookresearch:masterfrom
gji1 wants to merge 1 commit intofacebookresearch:masterfrom
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D27130180 |
gji1
added a commit
to gji1/ReAgent
that referenced
this pull request
Mar 18, 2021
…llable in oss (facebookresearch#423) Summary: Pull Request resolved: facebookresearch#423 Move functions `create_df_from_replay_buffer`, `set_seed`, `feature_transform`, and `validate_mdp_ids_seq_nums` from fblearner.flow.projects.rl to reagent, as well as class `ProblemDomain` from reagent.core.fb.parameters to reagent.core.parameters so that oss may call them in unit tests. Differential Revision: D27130180 fbshipit-source-id: caa1804eeea5189d9db417148aaa0bd54552fa2a
|
This pull request was exported from Phabricator. Differential Revision: D27130180 |
gji1
added a commit
to gji1/ReAgent
that referenced
this pull request
Mar 18, 2021
…unctions and classes (facebookresearch#423) Summary: Pull Request resolved: facebookresearch#423 Move functions `create_df_from_replay_buffer`, `set_seed`, `feature_transform`, and `validate_mdp_ids_seq_nums` from fblearner.flow.projects.rl to reagent, as well as class `ProblemDomain` from reagent.core.fb.parameters to reagent.core.parameters so that oss may call them in unit tests. Differential Revision: D27130180 fbshipit-source-id: e8ae73e4040f2053b5ccc59e7feb6599b0d70e6f
gji1
added a commit
to gji1/ReAgent
that referenced
this pull request
Mar 18, 2021
…unctions and classes (facebookresearch#423) Summary: Pull Request resolved: facebookresearch#423 Move functions `create_df_from_replay_buffer`, `set_seed`, `feature_transform`, and `validate_mdp_ids_seq_nums` from fblearner.flow.projects.rl to reagent, as well as class `ProblemDomain` from reagent.core.fb.parameters to reagent.core.parameters so that oss may call them in unit tests. Differential Revision: D27130180 fbshipit-source-id: e2035a3d2dad37a76764e898121b774f88e17d7e
…unctions and classes (facebookresearch#423) Summary: Pull Request resolved: facebookresearch#423 Move functions `create_df_from_replay_buffer`, `set_seed`, `feature_transform`, and `validate_mdp_ids_seq_nums` from fblearner.flow.projects.rl to reagent, as well as class `ProblemDomain` from reagent.core.fb.parameters to reagent.core.parameters so that oss may call them in unit tests. Reviewed By: czxttkl Differential Revision: D27130180 fbshipit-source-id: 0703b2d150f7c8dfa84d1d8eb23a14b992f5e233
|
This pull request was exported from Phabricator. Differential Revision: D27130180 |
gji1
added a commit
to gji1/ReAgent
that referenced
this pull request
Mar 18, 2021
…unctions and classes (facebookresearch#423) Summary: Pull Request resolved: facebookresearch#423 Move functions `create_df_from_replay_buffer`, `set_seed`, `feature_transform`, and `validate_mdp_ids_seq_nums` from fblearner.flow.projects.rl to reagent, as well as class `ProblemDomain` from reagent.core.fb.parameters to reagent.core.parameters so that oss may call them in unit tests. Differential Revision: D27130180 fbshipit-source-id: 6382ecea13d6ceef745d916c642f6aa7c3bed2e4
gji1
added a commit
to gji1/ReAgent
that referenced
this pull request
Mar 19, 2021
…unctions and classes (facebookresearch#423) Summary: Pull Request resolved: facebookresearch#423 Move functions `create_df_from_replay_buffer`, `set_seed`, `feature_transform`, and `validate_mdp_ids_seq_nums` from fblearner.flow.projects.rl to reagent, as well as class `ProblemDomain` from reagent.core.fb.parameters to reagent.core.parameters so that oss may call them in unit tests. Differential Revision: D27130180 fbshipit-source-id: 97b7950128ef594f3522dbd098408ec23107744b
gji1
added a commit
to gji1/ReAgent
that referenced
this pull request
Mar 19, 2021
…unctions and classes (facebookresearch#423) Summary: Pull Request resolved: facebookresearch#423 Move functions `create_df_from_replay_buffer`, `set_seed`, `feature_transform`, and `validate_mdp_ids_seq_nums` from fblearner.flow.projects.rl to reagent, as well as class `ProblemDomain` from reagent.core.fb.parameters to reagent.core.parameters so that oss may call them in unit tests. Differential Revision: D27130180 fbshipit-source-id: 80daea3a0e51c152ee57b6c38fa787f3c5fe660e
|
This pull request has been merged in 2cf5f63. |
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
…unctions and classes (#423) Summary: Pull Request resolved: #423 Move functions `create_df_from_replay_buffer`, `set_seed`, `feature_transform`, and `validate_mdp_ids_seq_nums` from fblearner.flow.projects.rl to reagent, as well as class `ProblemDomain` from reagent.core.fb.parameters to reagent.core.parameters so that oss may call them in unit tests. Reviewed By: czxttkl Differential Revision: D27130180 fbshipit-source-id: a06b7e8d5d683bb82a214bdab67b7e7e0ea71f2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Move functions
create_df_from_replay_buffer,set_seed,feature_transform, andvalidate_mdp_ids_seq_numsfrom fblearner.flow.projects.rl to reagent, so that oss may call them in unit tests.Differential Revision: D27130180