move model managers out of workflow (#421)#429
Closed
czxttkl wants to merge 1 commit intofacebookresearch:masterfrom
Closed
move model managers out of workflow (#421)#429czxttkl wants to merge 1 commit intofacebookresearch:masterfrom
czxttkl wants to merge 1 commit intofacebookresearch:masterfrom
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D27073406 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D27073406 |
czxttkl
added a commit
to czxttkl/ReAgent
that referenced
this pull request
Mar 20, 2021
Summary: Pull Request resolved: facebookresearch#429 Pull Request resolved: facebookresearch#421 Differential Revision: D27073406 fbshipit-source-id: 93e3ea04fb1b14cff9b8fc8e7b437c82d71b5ab5
czxttkl
force-pushed
the
export-D27073406
branch
from
e0edd55 to
1a1dc38
Compare
czxttkl
added a commit
to czxttkl/ReAgent
that referenced
this pull request
Mar 20, 2021
Summary: Pull Request resolved: facebookresearch#429 Pull Request resolved: facebookresearch#421 Differential Revision: D27073406 fbshipit-source-id: 0b57c4d5016c8abccd1e5aa6419938f767740ec4
czxttkl
force-pushed
the
export-D27073406
branch
from
1a1dc38 to
90026e3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D27073406 |
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
- Coverage 82.34% 82.32% -0.03%
==========================================
Files 312 312
Lines 17841 17848 +7
Branches 42 42
==========================================
+ Hits 14691 14693 +2
- Misses 3126 3131 +5
Partials 24 24
Continue to review full report at Codecov.
|
Summary: Pull Request resolved: facebookresearch#429 Pull Request resolved: facebookresearch#421 Now, for each model manager, it has an OSS implementation in `reagent.model_manager` and internal implementation in `reagent.model_manager.fb`. The internal version mostly inherits from the OSS counterpart with just a few methods overridden for internal usage. So the code has minimal duplication. Reviewed By: MisterTea Differential Revision: D27073406 fbshipit-source-id: dde588be1ad4e94d6afff3fcdf21bf81870cf54b
|
This pull request was exported from Phabricator. Differential Revision: D27073406 |
czxttkl
force-pushed
the
export-D27073406
branch
from
90026e3 to
654b1a9
Compare
|
This pull request has been merged in 9fc389b. |
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
Summary: Pull Request resolved: #429 Pull Request resolved: #421 Now, for each model manager, it has an OSS implementation in `reagent.model_manager` and internal implementation in `reagent.model_manager.fb`. The internal version mostly inherits from the OSS counterpart with just a few methods overridden for internal usage. So the code has minimal duplication. Reviewed By: MisterTea Differential Revision: D27073406 fbshipit-source-id: e6192960b8e132f5680adc2222993d9ff18216ef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Pull Request resolved: #421
Differential Revision: D27073406