Remove/Resolve import duplicates + add from_dict classmethod to MemoryNetworkInput#430
Closed
bankawas wants to merge 1 commit intofacebookresearch:masterfrom
Closed
Remove/Resolve import duplicates + add from_dict classmethod to MemoryNetworkInput#430bankawas wants to merge 1 commit intofacebookresearch:masterfrom
from_dict classmethod to MemoryNetworkInput#430bankawas wants to merge 1 commit intofacebookresearch:masterfrom
Conversation
…moryNetworkInput` Summary: - fix import errors (remove duplicates + resolve path for train_and_evaluate_generic) - add `from_dict` classmethod to `MemoryNetworkInput` Reviewed By: kaiwenw Differential Revision: D27134600 fbshipit-source-id: 5f9579e542b374de4438677e4e75b91adc10f9f2
|
This pull request was exported from Phabricator. Differential Revision: D27134600 |
|
This pull request has been merged in ad64447. |
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
…moryNetworkInput` (#430) Summary: Pull Request resolved: #430 - fix import errors (remove duplicates + resolve path for train_and_evaluate_generic) - add `from_dict` classmethod to `MemoryNetworkInput` Reviewed By: kaiwenw Differential Revision: D27134600 fbshipit-source-id: 41770d5c3d624f651a41513bc84ad844aafb10ec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
fix import errors (remove duplicates + resolve path for train_and_evaluate_generic)
add
from_dictclassmethod toMemoryNetworkInputReviewed By: kaiwenw
Differential Revision: D27134600