Remove additional layer of aggregation from logging#435
Closed
MisterTea wants to merge 1 commit intofacebookresearch:masterfrom
Closed
Remove additional layer of aggregation from logging#435MisterTea wants to merge 1 commit intofacebookresearch:masterfrom
MisterTea wants to merge 1 commit intofacebookresearch:masterfrom
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D27436575 |
…#435) Summary: Pull Request resolved: facebookresearch#435 Reviewed By: DavidV17 Differential Revision: D27436575 fbshipit-source-id: 7d6304afc825e297efc66c4986b9a1bdb67c42f4
|
This pull request was exported from Phabricator. Differential Revision: D27436575 |
MisterTea
force-pushed
the
export-D27436575
branch
from
c7dd875 to
44de463
Compare
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
+ Coverage 82.32% 82.36% +0.04%
==========================================
Files 312 312
Lines 17876 17850 -26
Branches 42 42
==========================================
- Hits 14717 14703 -14
+ Misses 3135 3123 -12
Partials 24 24
Continue to review full report at Codecov.
|
|
This pull request has been merged in 0e5fc53. |
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
Summary: Pull Request resolved: #435 Reviewed By: DavidV17 Differential Revision: D27436575 fbshipit-source-id: cbcc0439fca2e0258a1aac5ceff3ae1bb29258c2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D27436575