Skip to content

Migrate Seq2Reward to PyTorch Lightning#438

Closed
gji1 wants to merge 1 commit intofacebookresearch:masterfrom
gji1:export-D27497184
Closed

Migrate Seq2Reward to PyTorch Lightning#438
gji1 wants to merge 1 commit intofacebookresearch:masterfrom
gji1:export-D27497184

Conversation

@gji1
Copy link
Contributor

@gji1 gji1 commented Apr 3, 2021

Summary: Also adds TensorBoard plots into the reporter, and removes an unused unit test.

Differential Revision: D27497184

@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D27497184

@gji1 gji1 force-pushed the export-D27497184 branch from 24c66f8 to 2ed83d0 Compare April 3, 2021 00:50
gji1 added a commit to gji1/ReAgent that referenced this pull request Apr 3, 2021
Summary:
Pull Request resolved: facebookresearch#438

Also adds TensorBoard plots into the reporter, and removes an unused unit test.

Differential Revision: D27497184

fbshipit-source-id: a3257a14cef02b15921e00004cbbc2b3b2a0643f
@gji1 gji1 force-pushed the export-D27497184 branch from 2ed83d0 to d04e656 Compare April 3, 2021 00:51
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D27497184

gji1 added a commit to gji1/ReAgent that referenced this pull request Apr 5, 2021
Summary:
Pull Request resolved: facebookresearch#438

Also adds TensorBoard plots into the reporter, and removes an unused unit test.

Differential Revision: D27497184

fbshipit-source-id: 64490994bf461f9511925c798be324f5562e8f9e
@gji1 gji1 force-pushed the export-D27497184 branch from d04e656 to 677135a Compare April 5, 2021 23:59
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D27497184

1 similar comment
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D27497184

gji1 added a commit to gji1/ReAgent that referenced this pull request Apr 6, 2021
Summary:
Pull Request resolved: facebookresearch#438

Also adds TensorBoard plots into the reporter, and removes an unused unit test.

Differential Revision: D27497184

fbshipit-source-id: f30e90995ae1d3f6753c4af6905b7cc10c9ef869
@gji1 gji1 force-pushed the export-D27497184 branch from 677135a to fd9392d Compare April 6, 2021 02:17
@codecov-io
Copy link

Codecov Report

Merging #438 (fd9392d) into master (c6db9e1) will decrease coverage by 0.04%.
The diff coverage is 76.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage   82.37%   82.32%   -0.05%     
==========================================
  Files         312      311       -1     
  Lines       17851    17779      -72     
  Branches       42       42              
==========================================
- Hits        14704    14637      -67     
+ Misses       3123     3118       -5     
  Partials       24       24              
Impacted Files Coverage Δ
...ent/model_managers/model_based/seq2reward_model.py 82.14% <66.66%> (-4.07%) ⬇️
reagent/workflow/reporters/seq2reward_reporter.py 70.00% <70.00%> (ø)
reagent/training/world_model/seq2reward_trainer.py 86.20% <70.96%> (-11.33%) ⬇️
reagent/test/world_model/test_seq2reward.py 100.00% <100.00%> (ø)
reagent/workflow/training_reports.py 100.00% <100.00%> (ø)
reagent/net_builder/value/seq2reward_rnn.py 86.66% <0.00%> (-13.34%) ⬇️
reagent/gym/preprocessors/trainer_preprocessor.py 83.48% <0.00%> (-2.30%) ⬇️
reagent/gym/utils.py 77.40% <0.00%> (-1.13%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6db9e1...fd9392d. Read the comment docs.

Summary:
Pull Request resolved: facebookresearch#438

Also adds TensorBoard plots into the reporter, and removes an unused unit test.

Reviewed By: czxttkl

Differential Revision: D27497184

fbshipit-source-id: 0eb9c4e0df6d503adf3372ca47daefb799fc333f
@gji1 gji1 force-pushed the export-D27497184 branch from fd9392d to fe70ab5 Compare April 7, 2021 17:52
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D27497184

@facebook-github-bot
Copy link

This pull request has been merged in 766cdcc.

xuruiyang pushed a commit that referenced this pull request Sep 20, 2025
Summary:
Pull Request resolved: #438

Also adds TensorBoard plots into the reporter, and removes an unused unit test.

Reviewed By: czxttkl

Differential Revision: D27497184

fbshipit-source-id: 304ef603ec3457e7862492a2f82a482263846b30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants