Closed
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D29111772 |
kittipatv
added a commit
to kittipatv/ReAgent
that referenced
this pull request
Jun 14, 2021
Summary: Pull Request resolved: facebookresearch#487 We shouldn't need to yield the placeholder loss. Differential Revision: D29111772 fbshipit-source-id: 144329a08f41418cb6d9b9eb4009872198c03ff5
kittipatv
force-pushed
the
export-D29111772
branch
from
ebcfe26 to
c4d1768
Compare
|
This pull request was exported from Phabricator. Differential Revision: D29111772 |
Summary: Pull Request resolved: facebookresearch#487 We shouldn't need to yield the placeholder loss. Differential Revision: D29111772 fbshipit-source-id: be8f6695ad6d192e118e2fdfa95a0cfc858dc340
|
This pull request was exported from Phabricator. Differential Revision: D29111772 |
kittipatv
force-pushed
the
export-D29111772
branch
from
c4d1768 to
dd1e5cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
=======================================
Coverage 83.01% 83.02%
=======================================
Files 322 322
Lines 19031 19030 -1
Branches 44 44
=======================================
Hits 15799 15799
+ Misses 3206 3205 -1
Partials 26 26
Continue to review full report at Codecov.
|
|
This pull request has been merged in 1e985fd. |
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
Summary: Pull Request resolved: #487 We shouldn't need to yield the placeholder loss. Differential Revision: D29111772 fbshipit-source-id: 0971221583bd9a5de770860ff15cc80eb8d749c3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: We shouldn't need to yield the placeholder loss.
Differential Revision: D29111772