Skip to content

ID list features support in SAC#489

Closed
kittipatv wants to merge 1 commit intofacebookresearch:masterfrom
kittipatv:export-D29144000
Closed

ID list features support in SAC#489
kittipatv wants to merge 1 commit intofacebookresearch:masterfrom
kittipatv:export-D29144000

Conversation

@kittipatv
Copy link
Contributor

Differential Revision: D29144000

@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D29144000

kittipatv added a commit to kittipatv/ReAgent that referenced this pull request Jun 15, 2021
Summary: Pull Request resolved: facebookresearch#489

Differential Revision: D29144000

fbshipit-source-id: 544d0039b7e93876b02a3189d3f9e621d35e7be6
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D29144000

Summary: Pull Request resolved: facebookresearch#489

Differential Revision: D29144000

fbshipit-source-id: 6f5006f404450b9cf572a4234349468bfdc686d5
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D29144000

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2021

Codecov Report

Merging #489 (82c2f63) into master (c1bbf57) will decrease coverage by 0.00%.
The diff coverage is 87.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage   82.83%   82.83%   -0.01%     
==========================================
  Files         324      324              
  Lines       19113    19136      +23     
  Branches       44       44              
==========================================
+ Hits        15832    15851      +19     
- Misses       3255     3259       +4     
  Partials       26       26              
Impacted Files Coverage Δ
reagent/model_managers/actor_critic/sac.py 100.00% <ø> (ø)
reagent/model_managers/actor_critic/td3.py 97.43% <ø> (ø)
reagent/model_managers/discrete/discrete_crr.py 74.19% <ø> (ø)
...ilder/continuous_actor/gaussian_fully_connected.py 91.89% <76.92%> (-8.11%) ⬇️
reagent/gym/policies/predictor_policies.py 90.47% <80.00%> (-1.05%) ⬇️
reagent/prediction/predictor_wrapper.py 75.39% <85.71%> (+0.07%) ⬆️
reagent/model_managers/actor_critic_base.py 93.96% <100.00%> (+0.05%) ⬆️
...lder/continuous_actor/dirichlet_fully_connected.py 100.00% <100.00%> (ø)
...nt/net_builder/continuous_actor/fully_connected.py 96.42% <100.00%> (+0.13%) ⬆️
...eagent/net_builder/continuous_actor_net_builder.py 72.72% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1bbf57...82c2f63. Read the comment docs.

@facebook-github-bot
Copy link

This pull request has been merged in d79d9fc.

xuruiyang pushed a commit that referenced this pull request Sep 20, 2025
Summary: Pull Request resolved: #489

Reviewed By: czxttkl

Differential Revision: D29144000

fbshipit-source-id: b72401ee3bb69f4973c32914a440e571d56241f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants