Closed
Conversation
Summary: Adds dedicated unit test for PPO Trainer, additionally: - Fixes a bug with fully connected value net - Fixes some bugs in PPO training around using value net - Adds possible_action_mask to DuelingQNetwork Differential Revision: D30114686 fbshipit-source-id: aaf773f36cafd2a1cf993a554eab1363e9a65c20
|
This pull request was exported from Phabricator. Differential Revision: D30114686 |
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
==========================================
+ Coverage 84.18% 84.39% +0.20%
==========================================
Files 327 328 +1
Lines 19397 19514 +117
Branches 44 44
==========================================
+ Hits 16329 16468 +139
+ Misses 3042 3020 -22
Partials 26 26
Continue to review full report at Codecov.
|
|
This pull request has been merged in 8d00eb1. |
|
This pull request has been reverted by 04fab8f. |
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
Summary: Pull Request resolved: #520 Adds dedicated unit test for PPO Trainer, additionally: - Fixes a bug with fully connected value net - Fixes some bugs in PPO training around using value net - Adds possible_action_mask to DuelingQNetwork Reviewed By: czxttkl Differential Revision: D30114686 fbshipit-source-id: 3735af1ea65429867d63f7da1462194242ad8254
|
This pull request has been reverted by e5355f8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds dedicated unit test for PPO Trainer, additionally:
Differential Revision: D30114686