Closed
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D30342897 |
igfox
added a commit
to igfox/ReAgent
that referenced
this pull request
Aug 16, 2021
Summary: Pull Request resolved: facebookresearch#526 Adds dedicated unit test for PPO Trainer, additionally: - Fixes a bug with fully connected value net - Fixes some bugs in PPO training around using value net - Adds possible_action_mask to DuelingQNetwork Note: a continuation of D30114686 (facebookresearch@8d00eb1), which I reverted after it caused some CircleCI failures Reviewed By: czxttkl Differential Revision: D30342897 fbshipit-source-id: fbc78b7b023c1d5bb61bf7fc782c45833f4ca071
igfox
force-pushed
the
export-D30342897
branch
from
1b43149 to
359b7fc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30342897 |
Summary: Pull Request resolved: facebookresearch#526 Adds dedicated unit test for PPO Trainer, additionally: - Fixes a bug with fully connected value net - Fixes some bugs in PPO training around using value net - Adds possible_action_mask to DuelingQNetwork Note: a continuation of D30114686 (facebookresearch@8d00eb1), which I reverted after it caused some CircleCI failures Reviewed By: czxttkl Differential Revision: D30342897 fbshipit-source-id: ea396ea54bc239a4b7aee3d32d91c9a65106e994
igfox
force-pushed
the
export-D30342897
branch
from
359b7fc to
b15add4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30342897 |
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
==========================================
+ Coverage 84.90% 85.11% +0.20%
==========================================
Files 330 331 +1
Lines 19315 19438 +123
Branches 44 44
==========================================
+ Hits 16399 16544 +145
+ Misses 2890 2868 -22
Partials 26 26
Continue to review full report at Codecov.
|
|
This pull request has been merged in 9b25610. |
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
Summary: Pull Request resolved: #526 Adds dedicated unit test for PPO Trainer, additionally: - Fixes a bug with fully connected value net - Fixes some bugs in PPO training around using value net - Adds possible_action_mask to DuelingQNetwork Note: a continuation of D30114686 (8d00eb1), which I reverted after it caused some CircleCI failures Reviewed By: czxttkl Differential Revision: D30342897 fbshipit-source-id: 9be5e86d234619e97e476e46556a4dee07e3b734
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds dedicated unit test for PPO Trainer, additionally:
Note: a continuation of D30114686 (8d00eb1), which I reverted after it caused some CircleCI failures
Differential Revision: D30342897