add optimize=False to reagent optimizer configs#581
Closed
alexnikulkov wants to merge 2 commits intofacebookresearch:mainfrom
Closed
add optimize=False to reagent optimizer configs#581alexnikulkov wants to merge 2 commits intofacebookresearch:mainfrom
alexnikulkov wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D32513683 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D32513683 |
alexnikulkov
added a commit
to alexnikulkov/ReAgent
that referenced
this pull request
Nov 17, 2021
Summary: Pull Request resolved: facebookresearch#581 A new attribute has been added to SGD and will be added to other optimizers in the future. We need to make a corresponding change to `OptimizerConfig` pytorch/pytorch#68052 Differential Revision: D32513683 fbshipit-source-id: f804db019fb97818359dd02b50caf8e372e32d66
alexnikulkov
force-pushed
the
export-D32513683
branch
from
1f3abc9 to
b6f9a67
Compare
Differential Revision: D32509203 fbshipit-source-id: 77c8ed2930904aba2107807cb0c92e683e5521ac
Summary: Pull Request resolved: facebookresearch#581 A new attribute has been added to SGD and will be added to other optimizers in the future. We need to make a corresponding change to `OptimizerConfig` pytorch/pytorch#68052 Differential Revision: D32513683 fbshipit-source-id: 742f0174bd996a6e3473170a572650124963d50a
|
This pull request was exported from Phabricator. Differential Revision: D32513683 |
alexnikulkov
force-pushed
the
export-D32513683
branch
from
b6f9a67 to
aa24671
Compare
|
This pull request has been merged in c932ee1. |
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
Summary: Pull Request resolved: #581 A new attribute has been added to SGD and will be added to other optimizers in the future. We need to make a corresponding change to `OptimizerConfig` pytorch/pytorch#68052 Reviewed By: czxttkl Differential Revision: D32513683 fbshipit-source-id: 61f4042c10f9843f73d886b9d8c1d90baa52c5c1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
A new attribute has been added to SGD and will be added to other optimizers in the future. We need to make a corresponding change to
OptimizerConfigpytorch/pytorch#68052
Differential Revision: D32513683