Skip to content

Fix another circleci test#586

Closed
czxttkl wants to merge 3 commits intofacebookresearch:mainfrom
czxttkl:export-D32584831
Closed

Fix another circleci test#586
czxttkl wants to merge 3 commits intofacebookresearch:mainfrom
czxttkl:export-D32584831

Conversation

@czxttkl
Copy link
Contributor

@czxttkl czxttkl commented Nov 21, 2021

Summary: as titled

Differential Revision: D32584831

@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D32584831

czxttkl added a commit to czxttkl/ReAgent that referenced this pull request Nov 21, 2021
Summary:
Pull Request resolved: facebookresearch#586

as titled

Differential Revision: D32584831

fbshipit-source-id: 01f7b714ad88fb8aacdc93da03aec0b34a98bb63
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D32584831

czxttkl added a commit to czxttkl/ReAgent that referenced this pull request Nov 21, 2021
Summary:
Pull Request resolved: facebookresearch#586

as titled

Differential Revision: D32584831

fbshipit-source-id: 1bf1a25d7211a56592b640c4ab3b65c933789408
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D32584831

@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D32584831

czxttkl added a commit to czxttkl/ReAgent that referenced this pull request Nov 21, 2021
Summary:
Pull Request resolved: facebookresearch#586

as titled

Differential Revision: D32584831

fbshipit-source-id: e15c7cc97bf6eabf4c765ddbca13ac29089c7ca0
czxttkl added a commit to czxttkl/ReAgent that referenced this pull request Nov 21, 2021
Summary:
Pull Request resolved: facebookresearch#586

as titled

Differential Revision: D32584831

fbshipit-source-id: ebfc974ecea719e9c701692505670ae8e97d5baf
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D32584831

czxttkl added a commit to czxttkl/ReAgent that referenced this pull request Nov 21, 2021
Summary:
Pull Request resolved: facebookresearch#586

as titled

Differential Revision: D32584831

fbshipit-source-id: df9bd6c58e241373f2f5b0aa62e42088789f80d8
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D32584831

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2021

Codecov Report

Merging #586 (6cc0ef0) into main (62661e3) will decrease coverage by 0.00%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
- Coverage   87.00%   87.00%   -0.01%     
==========================================
  Files         344      344              
  Lines       21607    21579      -28     
  Branches       44       44              
==========================================
- Hits        18799    18774      -25     
+ Misses       2782     2779       -3     
  Partials       26       26              
Impacted Files Coverage Δ
reagent/core/configuration.py 81.48% <ø> (ø)
reagent/core/dataclasses.py 76.59% <ø> (ø)
reagent/core/fb_checker.py 75.00% <ø> (ø)
reagent/core/oss_tensorboard_logger.py 93.61% <ø> (ø)
reagent/core/registry_meta.py 93.18% <ø> (ø)
reagent/core/running_stats.py 0.00% <ø> (ø)
reagent/core/utils.py 85.71% <ø> (-0.96%) ⬇️
reagent/data/data_fetcher.py 77.77% <ø> (ø)
reagent/data/manual_data_module.py 90.07% <ø> (ø)
reagent/data/oss_data_fetcher.py 86.09% <ø> (ø)
... and 142 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62661e3...6cc0ef0. Read the comment docs.

czxttkl added a commit to czxttkl/ReAgent that referenced this pull request Nov 21, 2021
Summary:
Pull Request resolved: facebookresearch#586

as titled

Differential Revision: D32584831

fbshipit-source-id: ee22f0c29ca0b63953385e944944675272230f99
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D32584831

czxttkl added a commit to czxttkl/ReAgent that referenced this pull request Nov 21, 2021
Summary:
Pull Request resolved: facebookresearch#586

as titled

Differential Revision: D32584831

fbshipit-source-id: 5ccd0acb73fc0c81faf17f0ff11ca0aa3d713ca5
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D32584831

Summary: Follow the instructions in T66611582. Now the only remaining problem is that headers must include copyright.

Differential Revision: D32583915

fbshipit-source-id: 0a4399c00e506122b2171f992a7ddaba74ab7a26
Summary: as titled

Differential Revision: D32584005

fbshipit-source-id: d1790d5b0d89c1f0b8d689365c5567e7075d897c
Summary:
Pull Request resolved: facebookresearch#586

as titled

Differential Revision: D32584831

fbshipit-source-id: 8d63fe31eb4bc563550e896eb6ad56a4210cbb71
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D32584831

@facebook-github-bot
Copy link

This pull request has been merged in 83b7fda.

xuruiyang pushed a commit that referenced this pull request Sep 20, 2025
Summary:
Pull Request resolved: #586

as titled

Reviewed By: alexnikulkov

Differential Revision: D32584831

fbshipit-source-id: 7bff346118ea56992ca2c4570432aff078110d1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants