Closed
Conversation
Summary: The test was flaky because: 1. The seed wasn't fixed 2. Both UCB1 and MetricUCB were estimating variance, so UCB1 wasn't always at a disadvantage Differential Revision: D33340651 fbshipit-source-id: a054d391e655eeb0af9ecb3a9780af6bc9242041
|
This pull request was exported from Phabricator. Differential Revision: D33340651 |
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
Summary: Pull Request resolved: #595 The test was flaky because: 1. The seed wasn't fixed 2. Both UCB1 and MetricUCB were estimating variance, so UCB1 wasn't always at a disadvantage Reviewed By: czxttkl Differential Revision: D33340651 fbshipit-source-id: 2e94997eb2a7c0c209ed1ecd62412900ed701152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The test was flaky because:
Differential Revision: D33340651