Skip to content

Import torchrec#620

Closed
czxttkl wants to merge 1 commit intofacebookresearch:mainfrom
czxttkl:export-D34942469
Closed

Import torchrec#620
czxttkl wants to merge 1 commit intofacebookresearch:mainfrom
czxttkl:export-D34942469

Conversation

@czxttkl
Copy link
Contributor

@czxttkl czxttkl commented Mar 16, 2022

Summary: Officially import torchrec

Differential Revision: D34942469

@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D34942469

czxttkl added a commit to czxttkl/ReAgent that referenced this pull request Mar 17, 2022
Summary:
Pull Request resolved: facebookresearch#620

Officially import torchrec

Differential Revision: D34942469

fbshipit-source-id: 8f1e189d14b01aeebcc40c48efac65930523b529
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D34942469

czxttkl added a commit to czxttkl/ReAgent that referenced this pull request Mar 17, 2022
Summary:
Pull Request resolved: facebookresearch#620

Officially import torchrec

Differential Revision: D34942469

fbshipit-source-id: a9cf96a8e6f9d31b00d9a9c5d8aa04cc0b1fc511
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D34942469

1 similar comment
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D34942469

czxttkl added a commit to czxttkl/ReAgent that referenced this pull request Mar 17, 2022
Summary:
Pull Request resolved: facebookresearch#620

Officially import torchrec

Differential Revision: D34942469

fbshipit-source-id: 6459527a1c469ae6805a3ca3ec52ef309d4171a1
czxttkl added a commit to czxttkl/ReAgent that referenced this pull request Mar 17, 2022
Summary:
Pull Request resolved: facebookresearch#620

Officially import torchrec

Differential Revision: D34942469

fbshipit-source-id: be79ac37455720ebb06cb860f2a454a51c5ee644
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D34942469

czxttkl added a commit to czxttkl/ReAgent that referenced this pull request Mar 17, 2022
Summary:
Pull Request resolved: facebookresearch#620

Officially import torchrec

Differential Revision: D34942469

fbshipit-source-id: 37013f978928d8105ca6ac3c4d212092a7176521
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D34942469

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #620 (4a54eab) into main (180cf14) will increase coverage by 0.93%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
+ Coverage   85.89%   86.83%   +0.93%     
==========================================
  Files         351      350       -1     
  Lines       22253    22201      -52     
  Branches       44       44              
==========================================
+ Hits        19115    19279     +164     
+ Misses       3112     2896     -216     
  Partials       26       26              
Impacted Files Coverage Δ
reagent/test/core/test_utils.py 100.00% <ø> (+72.00%) ⬆️
reagent/test/preprocessing/test_transforms.py 99.69% <ø> (+6.02%) ⬆️
reagent/core/torch_utils.py 88.70% <100.00%> (+32.25%) ⬆️
reagent/core/types.py 86.67% <100.00%> (+0.21%) ⬆️
reagent/core/utils.py 85.10% <100.00%> (+2.12%) ⬆️
reagent/models/embedding_bag_concat.py 100.00% <100.00%> (ø)
reagent/models/synthetic_reward_sparse_arch.py 60.00% <100.00%> (+34.73%) ⬆️
...reward/single_step_synthetic_reward_sparse_arch.py 58.33% <100.00%> (ø)
reagent/preprocessing/transforms.py 93.31% <100.00%> (+16.86%) ⬆️
reagent/test/base/test_utils.py 100.00% <100.00%> (+30.43%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 180cf14...4a54eab. Read the comment docs.

czxttkl added a commit to czxttkl/ReAgent that referenced this pull request Mar 22, 2022
Summary:
Pull Request resolved: facebookresearch#620

Officially import torchrec

Reviewed By: alexnikulkov

Differential Revision: D34942469

fbshipit-source-id: a1c45580936d1e5e7f9acdc3bd4e699cb992e4c9
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D34942469

Summary:
Pull Request resolved: facebookresearch#620

Officially import torchrec

Reviewed By: alexnikulkov

Differential Revision: D34942469

fbshipit-source-id: 8f2f7d58e5799be98cf460b6eb5522ec7a272e01
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D34942469

xuruiyang pushed a commit that referenced this pull request Sep 20, 2025
Summary:
Pull Request resolved: #620

Officially import torchrec

Reviewed By: alexnikulkov

Differential Revision: D34942469

fbshipit-source-id: d4d47f4e90ff99f738f27c0720fd5462f40abe86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants