Skip to content

check input for parametric dqn#635

Closed
czxttkl wants to merge 1 commit intofacebookresearch:mainfrom
czxttkl:export-D36021439
Closed

check input for parametric dqn#635
czxttkl wants to merge 1 commit intofacebookresearch:mainfrom
czxttkl:export-D36021439

Conversation

@czxttkl
Copy link
Contributor

@czxttkl czxttkl commented Apr 28, 2022

Summary: as titled

Differential Revision: D36021439

@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D36021439

Summary:
Pull Request resolved: facebookresearch#635

as titled

Reviewed By: alexnikulkov

Differential Revision: D36021439

fbshipit-source-id: 73f57df2861fc34b9fa54145555ea8e75a513f42
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D36021439

@czxttkl czxttkl force-pushed the export-D36021439 branch from 6d2674b to 73c29ec Compare May 14, 2022 18:59
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2022

Codecov Report

Merging #635 (73c29ec) into main (8fb0706) will increase coverage by 7.65%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
+ Coverage   79.40%   87.05%   +7.65%     
==========================================
  Files         354      354              
  Lines       22468    22474       +6     
  Branches       44       44              
==========================================
+ Hits        17840    19565    +1725     
+ Misses       4602     2883    -1719     
  Partials       26       26              
Impacted Files Coverage Δ
reagent/training/parametric_dqn_trainer.py 85.10% <100.00%> (+1.01%) ⬆️
reagent/models/synthetic_reward_sparse_arch.py 58.58% <0.00%> (-2.03%) ⬇️
reagent/training/world_model/mdnrnn_trainer.py 74.19% <0.00%> (+1.61%) ⬆️
reagent/model_utils/seq2slate_utils.py 82.85% <0.00%> (+2.85%) ⬆️
reagent/gym/tests/test_gym_offline.py 98.48% <0.00%> (+3.03%) ⬆️
reagent/training/reagent_lightning_module.py 87.30% <0.00%> (+3.17%) ⬆️
reagent/core/configuration.py 81.48% <0.00%> (+4.93%) ⬆️
reagent/models/seq2slate.py 73.36% <0.00%> (+6.79%) ⬆️
reagent/core/types.py 86.67% <0.00%> (+7.14%) ⬆️
reagent/gym/types.py 95.18% <0.00%> (+9.63%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb0706...73c29ec. Read the comment docs.

xuruiyang pushed a commit that referenced this pull request Sep 20, 2025
Summary:
Pull Request resolved: #635

as titled

Reviewed By: alexnikulkov

Differential Revision: D36021439

fbshipit-source-id: ce008f941caf2d2b137851662a0b7926bd8520f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants