Add unit tests for DQNTrainerBaseLightning class#653
Closed
dkorenkevych wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Add unit tests for DQNTrainerBaseLightning class#653dkorenkevych wants to merge 1 commit intofacebookresearch:mainfrom
dkorenkevych wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D37673366 |
dkorenkevych
force-pushed
the
export-D37673366
branch
from
d26f3c3 to
216d921
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37673366 |
dkorenkevych
added a commit
to dkorenkevych/ReAgent
that referenced
this pull request
Jul 14, 2022
Summary: Pull Request resolved: facebookresearch#653 Add test_dqn_base.py file with unit tests for the methods in DQNTrainerBaseLightning class. Differential Revision: D37673366 fbshipit-source-id: 20e42805a18823a626e2de689f23f48ad0a6d57b
dkorenkevych
force-pushed
the
export-D37673366
branch
from
216d921 to
002d952
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37673366 |
dkorenkevych
added a commit
to dkorenkevych/ReAgent
that referenced
this pull request
Jul 15, 2022
Summary: Pull Request resolved: facebookresearch#653 Add test_dqn_base.py file with unit tests for the methods in DQNTrainerBaseLightning class. Differential Revision: D37673366 fbshipit-source-id: 4dcd032a0c142d80c9c97d04b5cf06b296e04c99
Summary: Pull Request resolved: facebookresearch#653 Add test_dqn_base.py file with unit tests for the methods in DQNTrainerBaseLightning class. Reviewed By: czxttkl Differential Revision: D37673366 fbshipit-source-id: f4c4710a53996085f7fd572e5088728c77b5eb21
dkorenkevych
force-pushed
the
export-D37673366
branch
from
002d952 to
f4013a2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37673366 |
dkorenkevych
added a commit
to dkorenkevych/ReAgent
that referenced
this pull request
Aug 2, 2022
Summary: Pull Request resolved: facebookresearch#653 Add test_dqn_base.py file with unit tests for the methods in DQNTrainerBaseLightning class. Reviewed By: czxttkl Differential Revision: D37673366 fbshipit-source-id: ade16ae9b299b5dbc98d1167f7d3f4b67e240ad8
Codecov Report
@@ Coverage Diff @@
## main #653 +/- ##
==========================================
+ Coverage 87.21% 87.34% +0.13%
==========================================
Files 354 355 +1
Lines 22709 22928 +219
Branches 44 44
==========================================
+ Hits 19806 20027 +221
+ Misses 2877 2875 -2
Partials 26 26
Continue to review full report at Codecov.
|
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
Summary: Pull Request resolved: #653 Add test_dqn_base.py file with unit tests for the methods in DQNTrainerBaseLightning class. Reviewed By: czxttkl Differential Revision: D37673366 fbshipit-source-id: 43482dde9be06a0df1e8dd3bb16e92d508bc8a13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add test_dqn_base.py file with unit tests
for the methods in DQNTrainerBaseLightning class.
Differential Revision: D37673366