Skip to content

WIP - Multiview_Q#663

Closed
speedystream wants to merge 1 commit intofacebookresearch:mainfrom
speedystream:export-D38011818
Closed

WIP - Multiview_Q#663
speedystream wants to merge 1 commit intofacebookresearch:mainfrom
speedystream:export-D38011818

Conversation

@speedystream
Copy link

Summary: This is the first part of the diff. I have moved the model in to reagent. Moreover, I have made some refactoring.

Differential Revision: D38011818

Summary: This is the first part of the diff. I have moved the model in to reagent. Moreover, I have made some refactoring.

Differential Revision: D38011818

fbshipit-source-id: 79bb513dd27e4c109bbe7712ac11cc6429e35083
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D38011818

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #663 (a096aa0) into main (cc43b0f) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
- Coverage   87.21%   87.11%   -0.10%     
==========================================
  Files         354      355       +1     
  Lines       22709    22735      +26     
  Branches       44       44              
==========================================
  Hits        19806    19806              
- Misses       2877     2903      +26     
  Partials       26       26              
Impacted Files Coverage Δ
reagent/models/sparse_dqn.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc43b0f...a096aa0. Read the comment docs.

xuruiyang pushed a commit that referenced this pull request Sep 20, 2025
Summary:
Pull Request resolved: #663

This is the first part of the diff. I have moved the model in to reagent. Moreover, I have made some refactoring.

Reviewed By: czxttkl

Differential Revision: D38011818

fbshipit-source-id: cb76646ed0e3149887180cbe642b1035afaace9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants