Reagent DeepRepresentLinucb [3/x] add params#669
Closed
BerenLuthien wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Reagent DeepRepresentLinucb [3/x] add params#669BerenLuthien wants to merge 1 commit intofacebookresearch:mainfrom
BerenLuthien wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D38813086 |
BerenLuthien
pushed a commit
to BerenLuthien/ReAgent
that referenced
this pull request
Aug 18, 2022
Summary: Pull Request resolved: facebookresearch#669 add `DeepRepresentLinUCBTrainerParameters` for DeepRepresentLinUCB Differential Revision: D38813086 fbshipit-source-id: 7915b4310b8874d388dcaaff79b06433e9b79f95
BerenLuthien
force-pushed
the
export-D38813086
branch
from
f44f77d to
b428aa0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D38813086 |
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
==========================================
- Coverage 87.39% 87.37% -0.02%
==========================================
Files 362 362
Lines 23125 23129 +4
Branches 44 44
==========================================
- Hits 20209 20208 -1
- Misses 2890 2895 +5
Partials 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
BerenLuthien
pushed a commit
to BerenLuthien/ReAgent
that referenced
this pull request
Aug 18, 2022
Summary: Pull Request resolved: facebookresearch#669 - Background Previously we reused `LinUCBTrainerParameters`. But actually `DeepRepresentLinUCBTrainerParameters` is supposed to be a bit different, .e.g, it has an optimizer while `LinUCBTrainerParameters` does not. - What this Diff does: It might be better to add `DeepRepresentLinUCBTrainerParameters`. Differential Revision: D38813086 fbshipit-source-id: ff5f732739019cf3c4fdcc79576c24dc0df9f1b2
BerenLuthien
force-pushed
the
export-D38813086
branch
from
b428aa0 to
1c3d80f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D38813086 |
Summary: Pull Request resolved: facebookresearch#669 Add `DeepRepresentLinUCBTrainerParameters`. Reviewed By: alexnikulkov Differential Revision: D38813086 fbshipit-source-id: 90707c0bfcff5b35ccc98c08394d1facb4eecf02
|
This pull request was exported from Phabricator. Differential Revision: D38813086 |
BerenLuthien
force-pushed
the
export-D38813086
branch
from
1c3d80f to
e2872b0
Compare
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
Summary: Pull Request resolved: #669 Add `DeepRepresentLinUCBTrainerParameters`. Reviewed By: alexnikulkov Differential Revision: D38813086 fbshipit-source-id: e1cbe01ed100b9a8328fe6cd63e9672e1df269f1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: add
DeepRepresentLinUCBTrainerParametersfor DeepRepresentLinUCBDifferential Revision: D38813086