Skip to content

Fix TestDeepRepresentLinUCB#672

Closed
alexnikulkov wants to merge 2 commits intofacebookresearch:mainfrom
alexnikulkov:export-D38874439
Closed

Fix TestDeepRepresentLinUCB#672
alexnikulkov wants to merge 2 commits intofacebookresearch:mainfrom
alexnikulkov:export-D38874439

Conversation

@alexnikulkov
Copy link
Contributor

Summary:
The test was failing in CircleCI: https://app.circleci.com/pipelines/github/facebookresearch/ReAgent/2491/workflows/e153e4b9-795d-4c30-a3ff-6e4411b7dbf2/jobs/24796
I removed unnecessary parts which were breaking the test

Reviewed By: czxttkl

Differential Revision: D38874439

alexnik and others added 2 commits August 19, 2022 12:36
Summary:
CircleCI tests started failing. Example: https://app.circleci.com/pipelines/github/facebookresearch/ReAgent/2490/workflows/efbceb68-9a01-4889-8d82-3d4167af4643/jobs/24780
Root cause is a significant jump in protobuf version from 3.19.4 to 4.21.5. This was caused by an an updated dependency on protobuf in grcpio-tools.
I'm adding an upper limit on grcpio-tools version to prevent this error

Differential Revision: D38870120

fbshipit-source-id: 071b3fb111dbdc48406ef31bec478e8953f66711
Summary:
The test was failing in CircleCI: https://app.circleci.com/pipelines/github/facebookresearch/ReAgent/2491/workflows/e153e4b9-795d-4c30-a3ff-6e4411b7dbf2/jobs/24796
I removed unnecessary parts which were breaking the test

Reviewed By: czxttkl

Differential Revision: D38874439

fbshipit-source-id: ab11f182bc5fb305c12e219cd8398a42a3b00c8f
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D38874439

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #672 (7dce006) into main (9085aae) will increase coverage by 83.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            main     #672       +/-   ##
==========================================
+ Coverage   3.44%   87.37%   +83.92%     
==========================================
  Files        356      362        +6     
  Lines      22748    23129      +381     
  Branches       0       44       +44     
==========================================
+ Hits         784    20208    +19424     
+ Misses     21964     2895    -19069     
- Partials       0       26       +26     
Impacted Files Coverage Δ
...ent/test/training/cb/test_deep_represent_linucb.py 100.00% <ø> (+100.00%) ⬆️
...ng/src/main/scala/com/facebook/spark/rl/Udfs.scala 93.75% <0.00%> (ø)
reagent/test/test_data/ex_mdps.py 96.42% <0.00%> (ø)
.../src/main/scala/com/facebook/spark/rl/Helper.scala 66.66% <0.00%> (ø)
...rc/main/scala/com/facebook/spark/rl/Timeline.scala 84.41% <0.00%> (ø)
...cala/com/facebook/spark/rl/MultiStepTimeline.scala 92.72% <0.00%> (ø)
...c/main/scala/com/facebook/spark/rl/Constants.scala 100.00% <0.00%> (ø)
reagent/core/multiprocess_utils.py 23.07% <0.00%> (+23.07%) ⬆️
reagent/models/seq2slate_reward.py 25.56% <0.00%> (+25.56%) ⬆️
reagent/gym/envs/pomdp/state_embed_env.py 26.31% <0.00%> (+26.31%) ⬆️
... and 330 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

xuruiyang pushed a commit that referenced this pull request Sep 20, 2025
Summary:
Pull Request resolved: #672

The test was failing in CircleCI: https://app.circleci.com/pipelines/github/facebookresearch/ReAgent/2491/workflows/e153e4b9-795d-4c30-a3ff-6e4411b7dbf2/jobs/24796
I removed unnecessary parts which were breaking the test

Reviewed By: czxttkl

Differential Revision: D38874439

fbshipit-source-id: 74fe760014b5152d8a59f676beb4c8fa96e15798
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants