Enable FX tracing on the dense-only RL model#674
Closed
zxpmirror1994 wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Enable FX tracing on the dense-only RL model#674zxpmirror1994 wants to merge 1 commit intofacebookresearch:mainfrom
zxpmirror1994 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: FX tracing is a pre-requisite of GMS. The current dense-only RL model is not FX traceable. In this diff the model is tweaked to enable FX tracing without any potential behavior change. Differential Revision: D38835020 fbshipit-source-id: 8f6f1a166f34f08a4743ddfb1bb7f97a5aab4f5b
|
This pull request was exported from Phabricator. Differential Revision: D38835020 |
Codecov Report
@@ Coverage Diff @@
## main #674 +/- ##
=======================================
Coverage 87.46% 87.47%
=======================================
Files 366 366
Lines 23351 23364 +13
Branches 44 44
=======================================
+ Hits 20424 20437 +13
Misses 2901 2901
Partials 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
xuruiyang
pushed a commit
that referenced
this pull request
Sep 20, 2025
Summary: Pull Request resolved: #674 FX tracing is a pre-requisite of GMS. The current dense-only RL model is not FX traceable. In this diff the model is tweaked to enable FX tracing without any potential behavior change. Reviewed By: czxttkl Differential Revision: D38835020 fbshipit-source-id: 96fd835b44bf42bff42459f0d37654a802bd537d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: FX tracing is a pre-requisite of GMS. The current dense-only RL model is not FX traceable. In this diff the model is tweaked to enable FX tracing without any potential behavior change.
Differential Revision: D38835020